Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize a convention for using MP Config to override annotation attributes? #400

Closed
njr-11 opened this issue Feb 7, 2019 · 3 comments
Assignees

Comments

@njr-11
Copy link

njr-11 commented Feb 7, 2019

MicroProfile Fault Tolerance already defines a way to use MicroProfile Config to override annotation values,
https://download.eclipse.org/microprofile/microprofile-fault-tolerance-2.0/microprofile-fault-tolerance-spec.html#configuration

MicroProfile Concurrency very nearly introduced a slightly different way of doing the same thing for override of its own config annotations, but having discovered the FaultTolerance approach, is now switching to align with the FaultTolerance approach so that MicroProfile specs can be consistent.

It would be helpful if MicroProfile Config spec itself defined the convention, because that is where new specifications will look before coming up with their own approaches.

@FroMage
Copy link

FroMage commented Feb 8, 2019

Very good idea!

@Emily-Jiang
Copy link
Member

Let's discuss this in this week's hangout

@jmesnil jmesnil assigned jmesnil and njr-11 and unassigned jmesnil Aug 2, 2019
@njr-11
Copy link
Author

njr-11 commented Aug 5, 2019

Closing because this issue has been taken up by MicroProfile in general, and is being tracked under the following issue instead under the general MicroProfile repository:
eclipse/microprofile#98

@njr-11 njr-11 closed this as completed Aug 5, 2019
@dmlloyd dmlloyd added this to the MP Config future milestone Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants