Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microprofile must not pollute the user's home directory #90

Open
SvetlinZarev opened this issue Oct 25, 2016 · 3 comments
Open

Microprofile must not pollute the user's home directory #90

SvetlinZarev opened this issue Oct 25, 2016 · 3 comments

Comments

@SvetlinZarev
Copy link

The build of microprofile-conference created .microprofile directory in my home folder and downloaded node+npm. After the build the directory was not deleted. The build must not pollute the user's home directory. If it needs anything for the build it should download it in a temporary folder in the OS's temp directory or a temp folder in the project directory.

@karianna karianna added this to the 1.0.0 milestone Oct 26, 2016
@AndyGee
Copy link
Contributor

AndyGee commented Oct 27, 2016

It should be the users tmp directory at most, but 'never' cleaned by the build clean - We could add a maven profile to clean to ensure it's a protected call.
We should also add some docs to make this visible and configurable (using the frontend-plugin).
The nodejs+npm used for the build must not interfere with a users installation, so the .microprofile dir is used to download the build specific versions by the frontend-plugin.
The OS tmp would be to volatile for day to day builds.

@SvetlinZarev
Copy link
Author

The OS tmp would be to volatile for day to day builds

Nodejs is cached in the local maven repository, so that should not be a problem.

An alternative would be to create the .microprofile directory in ${project.basedir} or ${project.build.directory}

but 'never' cleaned by the build clean

Why not ? Maven would just extract the nodejs zip for the next build and will not download anything. The delay would be unnoticeable.

@AndyGee
Copy link
Contributor

AndyGee commented Nov 1, 2016

I'll try it in the ${project.basedir} and see how the day to day is affected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants