Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With Xtext and MWE going to 2024-03 as minimal tp and J17 we should follow #365

Closed
cdietrich opened this issue Dec 11, 2024 · 11 comments
Closed

Comments

@cdietrich
Copy link
Member

With Xtext and MWE going to 2024-03 as minimal tp and J17 we should follow

@mehmet-karaman maybe you can find some time.

for the J17 part check what was done in the MWE and Xtext repos

@mehmet-karaman
Copy link
Contributor

mehmet-karaman commented Dec 11, 2024

@cdietrich
I've finished my current task, I am continueing here now..

@mehmet-karaman
Copy link
Contributor

@cdietrich the Java 17 part is done.. Please check if it contains all known places.. The platform 2024-03 changes will follow.

@mehmet-karaman
Copy link
Contributor

mehmet-karaman commented Dec 13, 2024

@cdietrich I've a few questions on the min. platform and min. xtext tp task:

  • Xpect bases still on xtext 2.14.0, should we update also this to 2.34?
  • Why do we have version names in project names? Why we don't name them minimal_eclipse_xtext instead of eclipse_2023_03-xtext_2_31_0 and eclipse-xtext_nightly instead of eclipse_2024_06-xtext_nightly ?

@cdietrich
Copy link
Member Author

  • i dont think there is a specific reason for version names. => renaming is a good idea. may we also can put them just into the root folder as in xtext repo.
  • yes 2.34 / mwe 1.11/2.17 would be ok

@mehmet-karaman
Copy link
Contributor

mehmet-karaman commented Dec 13, 2024

Why does the xtext-r202403.target use the following repo https://download.eclipse.org/tools/orbit/simrel/orbit-aggregation/2025-03 ?
Shouldn't it be using the 2024-03 one? Shall I use the same?

@cdietrich
Copy link
Member Author

No idea. I guess just stupid search and replace
Maybe it should work without orbit at all too

@mehmet-karaman
Copy link
Contributor

@cdietrich do we have a script or something which sets these bundle-version=".." automatically? Or are we doing this manually? Because the Eclipse bundles have different version numbers for each bundle and I've to check the repository to find the according number.. Is there an easier way?

@cdietrich
Copy link
Member Author

i dont know
if you can reuse what sebastian has added to xtext.util at
eclipse-xtext/xtext#3293

@szarnekow
Copy link

i dont know if you can reuse what sebastian has added to xtext.util at eclipse-xtext/xtext#3293

It has some hardcoded assumptions about Xtext itself, but generally speaking it could serve as a blueprint for mwe2, too.

@mehmet-karaman
Copy link
Contributor

Thank you .. This was very helpful. Just doinng some cleanup and the commit will be ready.

@mehmet-karaman
Copy link
Contributor

This task is done. I am closing this issue ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants