Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Add features list for Wakaama #762

Conversation

LukasWoodtli
Copy link
Contributor

The list is taken from #729.

@LukasWoodtli
Copy link
Contributor Author

The information for the table is taken from @rpolitex. We need to update it. I think at least the section with supported data formats is not up-to-date any more.

Copy link
Contributor

@rettichschnidi rettichschnidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can not really say anything about the actual content, but have some nits. :)

doc/wakaama_features.rst Outdated Show resolved Hide resolved
doc/wakaama_features.rst Outdated Show resolved Hide resolved
doc/wakaama_features.rst Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented May 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@LukasWoodtli
Copy link
Contributor Author

@rettichschnidi @mlasch Could you have a look on that eventually?

Copy link
Contributor

@rettichschnidi rettichschnidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more nits, feel free to ignore any of it and merge.

doc/wakaama_features.rst Outdated Show resolved Hide resolved
doc/wakaama_features.rst Outdated Show resolved Hide resolved
doc/wakaama_features.rst Outdated Show resolved Hide resolved
doc/wakaama_features.rst Show resolved Hide resolved
doc/wakaama_features.rst Show resolved Hide resolved
Copy link

sonarcloud bot commented Sep 29, 2024

Copy link
Contributor

@rettichschnidi rettichschnidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM. I guess you did re-request the review by accident?

The table had too many columns. It's now split into two tables.
We added CBOR and SenML CBOR support to Wakaama.
@LukasWoodtli LukasWoodtli force-pushed the gardena/lw/doc_wakaama_features branch from 52fce66 to e4a8adb Compare November 5, 2024 08:38
Copy link

sonarcloud bot commented Nov 5, 2024

@LukasWoodtli LukasWoodtli merged commit 5dfefea into eclipse-wakaama:main Nov 6, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants