Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Improved Trivy scan #174

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Feat: Improved Trivy scan #174

merged 1 commit into from
Aug 29, 2023

Conversation

agg3fe
Copy link
Contributor

@agg3fe agg3fe commented Aug 28, 2023

Description

Improvements in Trivy scan:

  1. Modified the image ref to 'latest'
  2. Removed the unnecessary build image step because we test 'latest' image

@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

shijinrajbosch
shijinrajbosch approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@shijinrajbosch shijinrajbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bs-sili
Copy link
Contributor

bs-sili commented Aug 28, 2023

LGTM

tunacicek
tunacicek approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@tunacicek tunacicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tunacicek tunacicek merged commit b041125 into eclipse-tractusx:main Aug 29, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shijinrajbosch shijinrajbosch shijinrajbosch approved these changes

@tunacicek tunacicek tunacicek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@agg3fe @bs-sili @tunacicek @shijinrajbosch