Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Moving helm values from product-semantics to tractusx repository #431

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

agg3fe
Copy link
Contributor

@agg3fe agg3fe commented Jun 21, 2024

Description

Since product-semantics in catenax-ng will shutdown soon, so its important to move helm values from product-semantics to tractusx repository.

Related issue: #422

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@agg3fe agg3fe requested review from tunacicek and evegufy June 21, 2024 14:39
@agg3fe
Copy link
Contributor Author

agg3fe commented Jun 21, 2024

@evegufy Hi Evelyn, as we discussed last week, I am moving the helm values to tractusx repo. something similar to what you have done in portal repo. You can review my PR and let me know your thoughts.

Copy link

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd change the section in the notice in the following way:

Test Environments

The project contains deployment configuration specific to hosted test environments needed for integration and end-to-end testing. This configuration is maintained within the environments directory.

Generally, now that the association environments are coming up, I was thinking to rework the folder structure in the following manner.

project
│   README.md
│
└─── environments
 └─── association
    └─── argocd-app-templates
        │   file111.yaml
        │   file112.yaml
    └─── helm-values
        │   file111.yaml
        │   file112.yaml
 └─── consortia
    └─── argocd-app-templates
        │   file111.yaml
        │   file112.yaml
    └─── helm-values
        │   file111.yaml
        │   file112.yaml

Could you please change that accordingly?
It's fine that you have for now just the consortia subfolder, which should be removed once the move to the association environment was completed.

@agg3fe
Copy link
Contributor Author

agg3fe commented Jun 27, 2024

I'd change the section in the notice in the following way:

Test Environments

The project contains deployment configuration specific to hosted test environments needed for integration and end-to-end testing. This configuration is maintained within the environments directory.

Generally, now that the association environments are coming up, I was thinking to rework the folder structure in the following manner.

project
│   README.md
│
└─── environments
 └─── association
    └─── argocd-app-templates
        │   file111.yaml
        │   file112.yaml
    └─── helm-values
        │   file111.yaml
        │   file112.yaml
 └─── consortia
    └─── argocd-app-templates
        │   file111.yaml
        │   file112.yaml
    └─── helm-values
        │   file111.yaml
        │   file112.yaml

Could you please change that accordingly? It's fine that you have for now just the consortia subfolder, which should be removed once the move to the association environment was completed.

I have modified the notice file and also the folder structure.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The files in consortia/argocd-app-templates are the same like in association. I think we can remove the files here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole consortia folder will be removed as soon as consortium ends. so this is temporarily placed here.
Will need to refer to association folder from argoCD.

source:
path: charts/registry
repoURL: 'https://github.com/eclipse-tractusx/sldt-digital-twin-registry.git'
targetRevision: main
Copy link
Contributor

@tunacicek tunacicek Jun 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pointing to main and sync with main. Does it make sense to introduce chart.yml etc. to define helm versions?
Otherwise, it is not possible to define a released Helm version, as it always uses the Helm version from main.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I will change this to tagged versions instead of main branch.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we need to change the way it is.
Because this script runs one time to create the app.
If we keep it like this (main), the newest helm which is defined will be taken.
If you change to a tag - How it looks when we want to deploy a newer helm version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants