Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bpdm): post endpoint to upload business partner data using csv file #964

Merged

Conversation

SujitMBRDI
Copy link
Contributor

@SujitMBRDI SujitMBRDI commented Jun 12, 2024

Description

This pull request contains changes for new POST api endpoint on BPDM Gate service, which will accept the CSV file as input for upsetting business partner input data. This endpoint enable way for user to create/update business partner using file.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@SujitMBRDI
Copy link
Contributor Author

@nicoprow,
In general, I tried covering almost all necessary changes.
Just except, REST API conformity with permissions about new resource and will also adjust default realm files for both helm chart and test.

@SujitMBRDI SujitMBRDI force-pushed the feat/upload_partner_data_csv branch from 43a5b9f to 6f27e02 Compare June 18, 2024 04:10
@SujitMBRDI
Copy link
Contributor Author

@nicoprow, In general, I tried covering almost all necessary changes. Just except, REST API conformity with permissions about new resource and will also adjust default realm files for both helm chart and test.

@nicoprow, I have adapted changes this changes. Kindly review the changes made.

Copy link
Contributor

@nicoprow nicoprow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we add a new feature here we should update the POM version to 6.1.0-SNAPSHOT. Likewise, this version upgrade should be written in the Charts as well as described in a comment below

@SujitMBRDI SujitMBRDI force-pushed the feat/upload_partner_data_csv branch from 1b0a2dd to 2b91d5a Compare June 20, 2024 04:47
@SujitMBRDI SujitMBRDI requested a review from nicoprow June 20, 2024 05:41
@SujitMBRDI
Copy link
Contributor Author

Since we add a new feature here we should update the POM version to 6.1.0-SNAPSHOT. Likewise, this version upgrade should be written in the Charts as well as described in a comment below

I rebased current branch with main, so now just updated chart version to 5.0.3-SNAPSHOT as you already created SNAPSHOT versions.

@SujitMBRDI SujitMBRDI force-pushed the feat/upload_partner_data_csv branch from 922c515 to f5f06b2 Compare June 20, 2024 05:56
@nicoprow
Copy link
Contributor

nicoprow commented Jun 20, 2024

Since we add a new feature here we should update the POM version to 6.1.0-SNAPSHOT. Likewise, this version upgrade should be written in the Charts as well as described in a comment below

I rebased current branch with main, so now just updated chart version to 5.0.3-SNAPSHOT as you already created SNAPSHOT versions.

@SujitMBRDI
I the current app version is 6.0.1-SNAPSHOT. Since this pull request adds a new feature to the app, we need to increase the SNAPSHOT version to 6.1.0-SNAPSHOT. Likewise, we need to increase the chart's SNAPSHOT version to 5.1.0-SNAPSHOT as well as update its appVersion to the 6.1.0-SNAPSHOT.

@SujitMBRDI SujitMBRDI force-pushed the feat/upload_partner_data_csv branch from 979da5c to aadbd86 Compare June 20, 2024 07:42
@SujitMBRDI
Copy link
Contributor Author

Since we add a new feature here we should update the POM version to 6.1.0-SNAPSHOT. Likewise, this version upgrade should be written in the Charts as well as described in a comment below

I rebased current branch with main, so now just updated chart version to 5.0.3-SNAPSHOT as you already created SNAPSHOT versions.

@SujitMBRDI I the current app version is 6.0.1-SNAPSHOT. Since this pull request adds a new feature to the app, we need to increase the SNAPSHOT version to 6.1.0-SNAPSHOT. Likewise, we need to increase the chart's SNAPSHOT version to 5.1.0-SNAPSHOT as well as update its appVersion to the 6.1.0-SNAPSHOT.

@nicoprow, Done. I have adapted changes.

Copy link
Contributor

@nicoprow nicoprow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@nicoprow nicoprow merged commit 749aea6 into eclipse-tractusx:main Jun 20, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants