-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bpdm): post endpoint to upload business partner data using csv file #964
feat(bpdm): post endpoint to upload business partner data using csv file #964
Conversation
@nicoprow, |
43a5b9f
to
6f27e02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we add a new feature here we should update the POM version to 6.1.0-SNAPSHOT. Likewise, this version upgrade should be written in the Charts as well as described in a comment below
bpdm-gate/src/main/kotlin/org/eclipse/tractusx/bpdm/gate/model/PartnerUploadFileRow.kt
Outdated
Show resolved
Hide resolved
bpdm-gate/src/main/kotlin/org/eclipse/tractusx/bpdm/gate/util/PartnerFileUtil.kt
Outdated
Show resolved
Hide resolved
...-gate/src/test/kotlin/org/eclipse/tractusx/bpdm/gate/controller/PartnerUploadControllerIT.kt
Show resolved
Hide resolved
.../main/kotlin/org/eclipse/tractusx/bpdm/gate/api/model/response/PartnerUploadErrorResponse.kt
Show resolved
Hide resolved
bpdm-gate-api/src/main/kotlin/org/eclipse/tractusx/bpdm/gate/api/GatePartnerUploadApi.kt
Outdated
Show resolved
Hide resolved
1b0a2dd
to
2b91d5a
Compare
I rebased current branch with main, so now just updated chart version to 5.0.3-SNAPSHOT as you already created SNAPSHOT versions. |
922c515
to
f5f06b2
Compare
@SujitMBRDI |
979da5c
to
aadbd86
Compare
@nicoprow, Done. I have adapted changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Description
This pull request contains changes for new POST api endpoint on BPDM Gate service, which will accept the CSV file as input for upsetting business partner input data. This endpoint enable way for user to create/update business partner using file.
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: