Stored launch configs of nested projects shown twice #798
Labels
bug
Something isn't working
Comments
|
@mickaelistria can you please look into all those duplicate launch config issues. |
|
@jukzi this is a completely different menu so not related to #527 @Bananeweizen can you please explain from what Eclipse version this is a regression? |
|
@laeubi I'm not sure that this is a regression. I think it has always been that way. https://github.com/eclipse-platform/eclipse.platform/blame/9802acd4bfbe3995960cfaafd713c76fc1ceda74/debug/org.eclipse.debug.core/core/org/eclipse/debug/internal/core/LaunchConfiguration.java#L372 is unchanged since 15 years and that location comparison leads to projectA/project/B/C.launch not being considered the same as projectB/C.launch. |
jukzi
pushed a commit
to Bananeweizen/eclipse.platform
that referenced
this issue
Mar 8, 2024
…#798 Fixes eclipse-platform#798. m2e projects can be nested (e.g. modules stored inside a reactor). Launch configs stored the inner nested projects appear twice, because they are not equal with the old implementation checking only name and container. Therefore also check the resolved location if the containers are different. I've tested this with an m2e IDE containing such nested projects and stored launch configs. The duplicates are gone with the change.
HannesWell
pushed a commit
to Bananeweizen/eclipse.platform
that referenced
this issue
Sep 29, 2024
…#798 Fixes eclipse-platform#798. m2e projects can be nested (e.g. modules stored inside a reactor). Launch configs stored the inner nested projects appear twice, because they are not equal with the old implementation checking only name and container. Therefore also check the resolved location if the containers are different. I've tested this with an m2e IDE containing such nested projects and stored launch configs. The duplicates are gone with the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If projects are nested (which is typical for maven reactor and modules), then launch configs stored in the nested project are shown twice in the run drop down. It might be useful to implement equals/hashCode such that the absolute file system paths are compared (or to alternatively filter based on the absolute file system path).
The text was updated successfully, but these errors were encountered: