Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change DLT opt level based on option #20857

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

mpirvu
Copy link
Contributor

@mpirvu mpirvu commented Dec 19, 2024

Before this change one could force the optimization level of a particular DLT compilation through a command line option (dltOptLevel=...) only if the TR_DebugDLT env var was defined. This was done to avoid the overhead of searching the option subsets for a given method.
This commit allows one to specify the optimization level of DLT compilations without the need of an env var. Examples:
-Xjit:dltOptLevel=hot
-Xjit:{myMethod}(dltOptLevel=cold)
The overhead for searching option sets has been eliminated if no option subset uses the dltOptlevel= option

Depends on eclipse-omr/omr#7596

@mpirvu mpirvu requested a review from dsouzai as a code owner December 19, 2024 15:17
@mpirvu mpirvu added the depends:omr Pull request is dependent on a corresponding change in OMR label Dec 19, 2024
Before this change one could force the optimization
level of a particular DLT compilation through a
command line option (dltOptLevel=...) only if the
TR_DebugDLT env var was defined. This was done to avoid
the overhead of searching the option subsets for a
given method.
This commit allows one to specify the optimization level
of DLT compilations without the need of an env var.
Examples:
  -Xjit:dltOptLevel=hot
  -Xjit:{myMethod}(dltOptLevel=cold)
The overhead for searching option sets has been eliminated
if no option subset uses the dltOptlevel= option

Depends on eclipse-omr/omr#7596

Signed-off-by: Marius Pirvu <[email protected]>
@mpirvu
Copy link
Contributor Author

mpirvu commented Dec 19, 2024

Jenkins test sanity xlinux jdk21 depends eclipse/omr#master

@mpirvu
Copy link
Contributor Author

mpirvu commented Dec 19, 2024

The omr dependency has reached the openj9-omr repo, so this PR can be reviewed/merged.

Copy link
Contributor

@zl-wang zl-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zl-wang
Copy link
Contributor

zl-wang commented Dec 19, 2024

it has been tested. merging ...

@zl-wang zl-wang merged commit 4ed5932 into eclipse-openj9:master Dec 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:jit depends:omr Pull request is dependent on a corresponding change in OMR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants