Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenJDK java/lang/invoke/VarHandles/VarHandleTestMethod crash vmState=0x00040000 #18246

Closed
pshipton opened this issue Oct 6, 2023 · 11 comments · Fixed by #18315
Closed

OpenJDK java/lang/invoke/VarHandles/VarHandleTestMethod crash vmState=0x00040000 #18246

pshipton opened this issue Oct 6, 2023 · 11 comments · Fixed by #18315
Assignees
@hzongaro
Labels
blocker comp:jit comp:vm test failure
Milestone
Release 0.43 (Jav...

Comments

@pshipton
Copy link
Member

pshipton commented Oct 6, 2023

https://hyc-runtimes-jenkins.swg-devops.com/job/Test_openjdk11_j9_sanity.openjdk_s390x_linux_Personal_testList_1/27/ - OMR acceptance, ubu20s390x-svl-rt10-1
jdk_lang_0
java/lang/invoke/VarHandles/VarHandleTestMethodHandleAccessLong.java

18:06:47  Type=Segmentation error vmState=0x00040000
18:06:47  J9Generic_Signal_Number=00000018 Signal_Number=0000000b Error_Value=00000000 Signal_Code=00000001
18:06:47  Handler1=000003FFAD44D6D8 Handler2=000003FFAD3333D8 InaccessibleAddress=0000000000000000
18:06:47  gpr0=0000000000004E00 gpr1=000003FFA8038A20 gpr2=0000000000000278 gpr3=00000000000000FF
18:06:47  gpr4=0000000000000008 gpr5=0000000000000007 gpr6=0000000000D45A40 gpr7=000003FFAC67D558
18:06:47  gpr8=000003FF554F6B24 gpr9=0000000000E66300 gpr10=0000000000000001 gpr11=0000000000000000
18:06:47  gpr12=000000000D5A5BB8 gpr13=000003FFAD69C4F0 gpr14=000003FFAD4AE242 gpr15=000003FFAC67D090
18:06:47  psw=000003FFAD4B5194 mask=0705000180000000 fpc=00080000 bea=000003FFAD4ADAF6
18:06:47  fpr0 ffffffffffffffff (f: 4294967296.000000, d: -nan)
18:06:47  fpr1 ffffffff00000000 (f: 0.000000, d: -nan)
18:06:47  fpr2 000003ffad36c539 (f: 2906047744.000000, d: 2.172237e-311)
18:06:47  fpr3 2020202020202020 (f: 538976256.000000, d: 6.013470e-154)
18:06:47  fpr4 0000000000000007 (f: 7.000000, d: 3.458460e-323)
18:06:47  fpr5 a0c0a0c0a0c00000 (f: 2696937472.000000, d: -6.349662e-151)
18:06:47  fpr6 000003ff2c000a48 (f: 738200128.000000, d: 2.171166e-311)
18:06:47  fpr7 0000000000000000 (f: 0.000000, d: 0.000000e+00)
18:06:47  fpr8 0000000000041000 (f: 266240.000000, d: 1.315400e-318)
18:06:47  fpr9 00000000006b2ff0 (f: 7024624.000000, d: 3.470625e-317)
18:06:47  fpr10 000003ffac63f000 (f: 2892230656.000000, d: 2.172231e-311)
18:06:47  fpr11 00000000006b2fe0 (f: 7024608.000000, d: 3.470617e-317)
18:06:47  fpr12 0000000000ca4640 (f: 13256256.000000, d: 6.549461e-317)
18:06:47  fpr13 0000000000000000 (f: 0.000000, d: 0.000000e+00)
18:06:47  fpr14 0000000000000000 (f: 0.000000, d: 0.000000e+00)
18:06:47  fpr15 00000000006b2fd0 (f: 7024592.000000, d: 3.470610e-317)
18:06:47  Module=/home/jenkins/workspace/Test_openjdk11_j9_sanity.openjdk_s390x_linux_Personal_testList_1/openjdkbinary/j2sdk-image/lib/default/libj9vm29.so
18:06:47  Module_base_address=000003FFAD400000
18:06:47  Target=2_90_20231005_1665 (Linux 5.4.0-159-generic)
18:06:47  CPU=s390x (4 logical CPUs) (0x1f6179000 RAM)
18:06:47  ----------- Stack Backtrace -----------
18:06:47  _ZN32VM_BytecodeInterpreterCompressed3runEP10J9VMThread+0x7d04 (0x000003FFAD4B5194 [libj9vm29.so+0xb5194])
18:06:47  bytecodeLoopCompressed+0xf6 (0x000003FFAD4AD47E [libj9vm29.so+0xad47e])
18:06:47  c_cInterpreter+0x64 (0x000003FFAD5F8C74 [libj9vm29.so+0x1f8c74])
@pshipton
Copy link
Member Author

https://openj9-jenkins.osuosl.org/job/Test_openjdk11_j9_sanity.openjdk_aarch64_linux_OMR_testList_0/32
jdk_lang_0
java/lang/invoke/VarHandles/VarHandleTestMethodHandleAccessDouble.java

https://openj9-artifactory.osuosl.org/artifactory/ci-openj9/Test/Test_openjdk11_j9_sanity.openjdk_aarch64_linux_OMR_testList_0/32/openjdk_test_output.tar.gz

21:21:51  test VarHandleTestMethodHandleAccessDouble.testAccess("VarHandle -> MethodHandles.varHandleExactInvoker -> Static field", VarHandleBaseTest$MethodHandleAccessTestCase@60da480c): success
21:21:51  STDERR:
21:21:51  Unhandled exception
21:21:51  Type=Segmentation error vmState=0x00040000
21:21:51  J9Generic_Signal_Number=00000018 Signal_Number=0000000b Error_Value=00000000 Signal_Code=00000001
21:21:51  Handler1=0000FFFF89668F08 Handler2=0000FFFF895DE578 InaccessibleAddress=00000000000002A0
21:21:51  R0=0000000000000003 R1=00000000000002A0 R2=0000000000000000 R3=0000FFFF8402E300
21:21:51  R4=00000000001B6890 R5=0000FFFF83D35664 R6=0000000010000000 R7=000000000008CC40
21:21:51  R8=0000FFFF314F6B14 R9=0000000000000001 R10=0000000000000000 R11=0000000000002400
21:21:51  R12=0000135C9862A62C R13=0000FFFF30A25980 R14=00000000000000D1 R15=0000FFFF83DCA000
21:21:51  R16=0000FFFF30FDF710 R17=0000FFFF89C96150 R18=00000000FFC5CFE8 R19=00000000001B68D0
21:21:51  R20=00000000001B67F8 R21=0000FFFF314F6B9C R22=000000000008CC60 R23=0000FFFF898167D4
21:21:51  R24=0000000000000000 R25=0000FFFF898453D8 R26=00000000FFFFFFFF R27=0000FFFF8402E300
21:21:51  R28=0000FFFF896BC268 R29=0000FFFF30FDF160 R30=0000FFFF89789710 R31=0000FFFF30FDF150
21:21:51  PC=0000FFFF896BE4B8 SP=0000FFFF30FDF150 PSTATE=0000000060001000
21:21:51  V0 0000000000000005 (f: 5.000000, d: 2.470328e-323)
21:21:51  V1 00000000ffc5ffb0 (f: 4291166208.000000, d: 2.120118e-314)
21:21:51  V2 0000ffff30fdf7e8 (f: 821950464.000000, d: 1.390654e-309)
21:21:51  V3 0000ffff30fdf7d8 (f: 821950400.000000, d: 1.390654e-309)
21:21:51  V4 0000ffff30fdf7c8 (f: 821950400.000000, d: 1.390654e-309)
21:21:51  V5 0000ffff30fdf7b8 (f: 821950400.000000, d: 1.390654e-309)
21:21:51  V6 0000ffff30fdf7a8 (f: 821950400.000000, d: 1.390654e-309)
21:21:51  V7 0000ffff30fdf798 (f: 821950336.000000, d: 1.390654e-309)
21:21:51  V8 0000000000000000 (f: 0.000000, d: 0.000000e+00)
21:21:51  V9 0000000000000000 (f: 0.000000, d: 0.000000e+00)
21:21:51  V10 0000000000000000 (f: 0.000000, d: 0.000000e+00)
21:21:51  V11 0000000000000000 (f: 0.000000, d: 0.000000e+00)
21:21:51  V12 0000000000000000 (f: 0.000000, d: 0.000000e+00)
21:21:51  V13 0000000000000000 (f: 0.000000, d: 0.000000e+00)
21:21:51  V14 0000000000000000 (f: 0.000000, d: 0.000000e+00)
21:21:51  V15 0000000000000000 (f: 0.000000, d: 0.000000e+00)
21:21:51  V16 0000ffff30fdf788 (f: 821950336.000000, d: 1.390654e-309)
21:21:51  V17 0000ffff30fdf778 (f: 821950336.000000, d: 1.390654e-309)
21:21:51  V18 0000ffff30fdf768 (f: 821950336.000000, d: 1.390654e-309)
21:21:51  V19 0000ffff30fdf758 (f: 821950272.000000, d: 1.390654e-309)
21:21:51  V20 0000ffff30fdf748 (f: 821950272.000000, d: 1.390654e-309)
21:21:51  V21 0000ffff30fdf738 (f: 821950272.000000, d: 1.390654e-309)
21:21:51  V22 0000ffff30fdf728 (f: 821950272.000000, d: 1.390654e-309)
21:21:51  V23 00000000000000f0 (f: 240.000000, d: 1.185758e-321)
21:21:51  V24 0000000000000000 (f: 0.000000, d: 0.000000e+00)
21:21:51  V25 0000000000000000 (f: 0.000000, d: 0.000000e+00)
21:21:51  V26 0000000000000000 (f: 0.000000, d: 0.000000e+00)
21:21:51  V27 0000000000000000 (f: 0.000000, d: 0.000000e+00)
21:21:51  V28 4008000000000000 (f: 0.000000, d: 3.000000e+00)
21:21:51  V29 3ff0000000000000 (f: 0.000000, d: 1.000000e+00)
21:21:51  V30 4008000000000000 (f: 0.000000, d: 3.000000e+00)
21:21:51  V31 4008000000000000 (f: 0.000000, d: 3.000000e+00)
21:21:51  Module=/home/jenkins/workspace/Test_openjdk11_j9_sanity.openjdk_aarch64_linux_OMR_testList_0/openjdkbinary/j2sdk-image/lib/default/libj9vm29.so
21:21:51  Module_base_address=0000FFFF89632000
21:21:51  Target=2_90_20231007_419 (Linux 5.4.0-144-generic)
21:21:51  CPU=aarch64 (8 logical CPUs) (0x1efead000 RAM)
21:21:51  ----------- Stack Backtrace -----------
21:21:51  protectedBacktrace+0x18 (0x0000FFFF895DACE0 [libj9prt29.so+0x26ce0])
21:21:51  ---------------------------------------

@pshipton
Copy link
Member Author

@TobiAjila fyi

@tajila
Copy link
Contributor

tajila commented Oct 12, 2023

I believe this is the same issue as #18149

@tajila
Copy link
Contributor

tajila commented Oct 12, 2023

@Akira1Saitoh

@pshipton
Copy link
Member Author

@TobiAjila the first failure was on zlinux.

@pshipton pshipton mentioned this issue Oct 12, 2023
Closed
@tajila
Copy link
Contributor

tajila commented Oct 12, 2023 •
edited
Loading

The crash (the first one in this issue) occurs in an interpreter frame calling revealDirect

> !stackslots 0x00e61400
<e61400> *** BEGIN STACK WALK, flags = 00400001 walkThread = 15,078,400 ***
<e61400> 	ITERATE_O_SLOTS
<e61400> 	RECORD_BYTECODE_PC_OFFSET
<e61400> Initial values: walkSP = 0x0000000000E66300, PC = 0x000003FF554F6B21, literals = 0x0000000000D45A40, A0 = 0x0000000000E66348, j2iFrame = 0x0000000000E664E0, decomp = 0x0000000000000000
<e61400> Bytecode frame: bp = 0x0000000000E66330, sp = 0x0000000000E66300, pc = 0x000003FF554F6B21, cp = 0x0000000000D44070, arg0EA = 0x0000000000E66348, flags = 0x0000000000000000
<e61400> 	Method: java/lang/invoke/MethodHandles$Lookup.revealDirect(Ljava/lang/invoke/MethodHandle;)Ljava/lang/invoke/MethodHandleInfo; !j9method 0x0000000000D45A40
<e61400> 	Bytecode index = 53
<e61400> 	Using local mapper
<e61400> 	Locals starting at 0x0000000000E66348 for 0x0000000000000003 slots
<e61400> 		I-Slot: a0[0x0000000000E66348] = 0x0000000000E662D8
<e61400> 		O-Slot: a1[0x0000000000E66340] = 0x000000002CFE0770
<e61400> 		I-Slot: t2[0x0000000000E66338] = 0x0000000000000000
<e61400> 	Pending stack starting at 0x0000000000E66318 for UDATA(0x0000000000000004) slots
<e61400> 		O-Slot: p0[0x0000000000E66318] = 0x0000000000E662D8
<e61400> 		O-Slot: p1[0x0000000000E66310] = 0x000000000D4D3570
<e61400> 		O-Slot: p2[0x0000000000E66308] = 0x000000000D4D3570
<e61400> 		O-Slot: p3[0x0000000000E66300] = 0x000011110D4D3570
<e61400> Bytecode frame: bp = 0x0000000000E66360, sp = 0x0000000000E66350, pc = 0x000003FFADAA59EB, cp = 0x0000000000E51D90, arg0EA = 0x0000000000E66380, flags = 0x0000000000000000
<e61400> 	Method: VarHandleBaseTest.bind(Ljava/lang/invoke/VarHandle;Ljava/lang/invoke/MethodHandle;Ljava/lang/invoke/MethodType;)Ljava/lang/invoke/MethodHandle; !j9method 0x0000000000E528D8
<e61400> 	Bytecode index = 27
<e61400> 	Using local mapper
<e61400> 	Locals starting at 0x0000000000E66380 for 0x0000000000000004 slots
<e61400> 		O-Slot: a0[0x0000000000E66380] = 0x000000000D66F6F0
<e61400> 		O-Slot: a1[0x0000000000E66378] = 0x000000002CFE0770
<e61400> 		O-Slot: a2[0x0000000000E66370] = 0x000000000D6A3C48
<e61400> 		I-Slot: t3[0x0000000000E66368] = 0x0000000000000000
<e61400> Bytecode frame: bp = 0x0000000000E66398, sp = 0x0000000000E66388, pc = 0x000003FFADAA59A4, cp = 0x0000000000E51D90, arg0EA = 0x0000000000E663B8, flags = 0x0000000000000000
<e61400> 	Method: VarHandleBaseTest.varHandleExactInvoker(Ljava/lang/invoke/VarHandle;LVarHandleBaseTest$TestAccessMode;Ljava/lang/invoke/MethodType;)Ljava/lang/invoke/MethodHandle; !j9method 0x0000000000E528B8
<e61400> 	Bytecode index = 12
<e61400> 	Using local mapper
<e61400> 	Locals starting at 0x0000000000E663B8 for 0x0000000000000004 slots
<e61400> 		I-Slot: a0[0x0000000000E663B8] = 0x000000000D66F6F0
<e61400> 		I-Slot: a1[0x0000000000E663B0] = 0x000000000D66CC98
<e61400> 		I-Slot: a2[0x0000000000E663A8] = 0x000000000D6A3C48
<e61400> 		I-Slot: t3[0x0000000000E663A0] = 0x000000002CFE0770
<e61400> Bytecode frame: bp = 0x0000000000E663D0, sp = 0x0000000000E663C0, pc = 0x000003FF57AB97C0, cp = 0x0000000000F960C0, arg0EA = 0x0000000000E663F0, flags = 0x0000000000000000
<e61400> 	Method: VarHandleBaseTest$VarHandleToMethodHandle$$Lambda$74/0x0000000000000000.apply(Ljava/lang/Object;Ljava/lang/Object;Ljava/lang/Object;)Ljava/lang/Object; !j9method 0x0000000000F96178
<e61400> 	Bytecode index = 12
<e61400> 	Using local mapper
<e61400> 	Locals starting at 0x0000000000E663F0 for 0x0000000000000004 slots
<e61400> 		I-Slot: a0[0x0000000000E663F0] = 0x000000000D670330
<e61400> 		I-Slot: a1[0x0000000000E663E8] = 0x000000000D66F6F0
<e61400> 		I-Slot: a2[0x0000000000E663E0] = 0x000000000D66CC98
<e61400> 		I-Slot: a3[0x0000000000E663D8] = 0x000000000D6A3C48
<e61400> Bytecode frame: bp = 0x0000000000E66408, sp = 0x0000000000E663F8, pc = 0x000003FF2C0A6701, cp = 0x0000000000F2FEE0, arg0EA = 0x0000000000E66428, flags = 0x0000000000000000
<e61400> 	Method: VarHandleBaseTest$VarHandleToMethodHandle.apply(Ljava/lang/invoke/VarHandle;LVarHandleBaseTest$TestAccessMode;Ljava/lang/invoke/MethodType;)Ljava/lang/invoke/MethodHandle; !j9method 0x0000000000F30450
<e61400> 	Bytecode index = 9
<e61400> 	Using local mapper
<e61400> 	Locals starting at 0x0000000000E66428 for 0x0000000000000004 slots
<e61400> 		I-Slot: a0[0x0000000000E66428] = 0x000000000D66FD00
<e61400> 		I-Slot: a1[0x0000000000E66420] = 0x000000000D66F6F0
<e61400> 		I-Slot: a2[0x0000000000E66418] = 0x000000000D66CC98
<e61400> 		I-Slot: a3[0x0000000000E66410] = 0x000000000D6A3C48
<e61400> Bytecode frame: bp = 0x0000000000E66440, sp = 0x0000000000E66430, pc = 0x000003FF2C0A5BEE, cp = 0x0000000000F2F8C0, arg0EA = 0x0000000000E66460, flags = 0x0000000000000000
<e61400> 	Method: VarHandleBaseTest$Handles.lambda$get$0(LVarHandleBaseTest$TestAccessMode;Ljava/lang/invoke/MethodType;LVarHandleBaseTest$Handles$AccessModeAndType;)Ljava/lang/invoke/MethodHandle; !j9method 0x0000000000F2FC58
<e61400> 	Bytecode index = 10
<e61400> 	Using local mapper
<e61400> 	Locals starting at 0x0000000000E66460 for 0x0000000000000004 slots
<e61400> 		I-Slot: a0[0x0000000000E66460] = 0x000000002CFDFC80
<e61400> 		I-Slot: a1[0x0000000000E66458] = 0x000000000D66CC98
<e61400> 		I-Slot: a2[0x0000000000E66450] = 0x000000000D6A3C48
<e61400> 		I-Slot: a3[0x0000000000E66448] = 0x000000002CFE0700
<e61400> J2I frame: bp = 0x0000000000E664E0, sp = 0x0000000000E66468, pc = 0x000003FF57ABB5AC, cp = 0x0000000000FA9ED0, arg0EA = 0x0000000000E664F0, flags = 0x0000000010000000
<e61400> 	Method: VarHandleBaseTest$Handles$$Lambda$87/0x0000000000000000.apply(Ljava/lang/Object;)Ljava/lang/Object; !j9method 0x0000000000FA9FD8
<e61400> 	Bytecode index = 16
<e61400> 	Using local mapper
<e61400> 	Locals starting at 0x0000000000E664F0 for 0x0000000000000002 slots
<e61400> 		I-Slot: a0[0x0000000000E664F0] = 0x000000002CFE0710
<e61400> 		I-Slot: a1[0x0000000000E664E8] = 0x000000002CFE0700
<e61400> 	JIT-J2I-RegisterMap[0x0000000000E664C0] = UDATA(0x0000000000FA9D00) (jit_r6)
<e61400> 	JIT-J2I-RegisterMap[0x0000000000E664B8] = UDATA(0x0000000000000000) (jit_r7)
<e61400> 	JIT-J2I-RegisterMap[0x0000000000E664B0] = UDATA(0x000000002CFE0728) (jit_r8)
<e61400> 	JIT-J2I-RegisterMap[0x0000000000E664A8] = UDATA(0x0000000000000000) (jit_r9)
<e61400> 	JIT-J2I-RegisterMap[0x0000000000E664A0] = UDATA(0x0000000000000000) (jit_r10)
<e61400> 	JIT-J2I-RegisterMap[0x0000000000E66498] = UDATA(0x000000002CFE0700) (jit_r11)
<e61400> 	JIT-J2I-RegisterMap[0x0000000000E66490] = UDATA(0x0000000000000000) (jit_r12)
<e61400> JIT frame: bp = 0x0000000000E665B8, pc = 0x000003FF8DD0013C, unwindSP = 0x0000000000E664E8, cp = 0x0000000000CFC0E0, arg0EA = 0x0000000000E665D0, jitInfo = 0x000003FF6F61C3B8
<e61400> 	Method: java/util/HashMap.computeIfAbsent(Ljava/lang/Object;Ljava/util/function/Function;)Ljava/lang/Object; !j9method 0x0000000000CFCD68
<e61400> 	Bytecode index = 204, inlineDepth = 0, PC offset = 0x0000000000000D4E
<e61400> 	stackMap=0x000003FF6F61C69A, slots=I16(0x0003) parmBaseOffset=I16(0x0008), parmSlots=U16(0x0003), localBaseOffset=I16(0xFFD0)

However, it happens after OSR

22:06:14.599002380  0xE61400 j9codertvm(j9jit).57 Entry      >decompileMethodFrameIterator
22:06:14.599002690  0xE61400 j9codertvm(j9jit).58 Event       outgoing arg count is 1
22:06:14.599002798  0xE61400 j9codertvm(j9jit).63 Exit       <decompileMethodFrameIterator
22:06:14.599004158  0xE61400 j9codertvm(j9jit).57 Entry      >decompileMethodFrameIterator
22:06:14.599005839  0xE61400 j9codertvm(j9jit).62 Exit       <decompileMethodFrameIterator - finish: previous is BC - set flag
22:06:14.599006001  0xE61400 j9vm.683             Exit       <WalkStackFrames - walkThread=0xe61400, rc=0
22:06:14.599006092  0xE61400 j9codertvm(j9jit).71 Entry      >performDecompile
22:06:14.599008189  0xE61400 j9codertvm(j9jit).73 Event       building bytecode frame at 0xe66350
22:06:14.599008638  0xE61400 j9codertvm(j9jit).114 Exit       <performDecompile - new SP = 0xe66318, literals = 0xd45a40, pc = 0x3ff554f6aed
22:06:14.599009236  0xE61400 j9codertvm(j9jit).122 Exit       <DecompileAtCurrentPC exit

> !j9method 0xd45a40
J9Method at 0xd45a40 {
  Fields for J9Method:
	0x0: U8* bytecodes = !j9x 0x000003FF554F6AEC // "+�"
	0x8: struct J9ConstantPool* constantPool = !j9constantpool 0x0000000000D44070 (flags = 0x0)
	0x10: void* methodRunAddress = !j9x 0x0000000000000006
	0x18: volatile void* extra = !j9x 0x00000000000004EB
}
Signature: java/lang/invoke/MethodHandles$Lookup.revealDirect(Ljava/lang/invoke/MethodHandle;)Ljava/lang/invoke/MethodHandleInfo; !bytecodes 0x0000000000D45A40
ROM Method: !j9rommethod 0x000003FF554F6AD8
Next Method: !j9method 0x0000000000D45A60

it looks like OSR was triggered in the 1 invokevirtual 224 java/lang/invoke/MethodHandle.canRevealDirect()Z call

@tajila
Copy link
Contributor

tajila commented Oct 12, 2023

@0xdaryl Please take a look

@pshipton pshipton changed the title OpenJDK java/lang/invoke/VarHandles/VarHandleTestMethodHandleAccessLong crash vmState=0x00040000 OpenJDK java/lang/invoke/VarHandles/VarHandleTestMethod crash vmState=0x00040000 Oct 13, 2023
@pshipton
Copy link
Member Author

pshipton commented Oct 13, 2023 •
edited
Loading

https://openj9-jenkins.osuosl.org/job/Test_openjdk11_j9_sanity.openjdk_aarch64_linux_Nightly_testList_1/67
jdk_lang_1
java/lang/invoke/VarHandles/VarHandleTestMethodHandleAccessChar.java

https://openj9-artifactory.osuosl.org/artifactory/ci-openj9/Test/Test_openjdk11_j9_sanity.openjdk_aarch64_linux_Nightly_testList_1/67/openjdk_test_output.tar.gz

https://openj9-jenkins.osuosl.org/job/Test_openjdk11_j9_sanity.openjdk_aarch64_linux_OMR_testList_0/35
jdk_lang_0
java/lang/invoke/VarHandles/VarHandleTestMethodHandleAccessBoolean.java

https://openj9-artifactory.osuosl.org/artifactory/ci-openj9/Test/Test_openjdk11_j9_sanity.openjdk_aarch64_linux_OMR_testList_0/35/openjdk_test_output.tar.gz

@hzongaro
Copy link
Member

This failure began when pull request #14074 was merged — which was my own — so I suspect that there is either a bug in my fix or it has exposed another problem. Investigating.

@hzongaro hzongaro self-assigned this Oct 16, 2023
@pshipton
Copy link
Member Author

https://openj9-jenkins.osuosl.org/job/Test_openjdk11_j9_sanity.openjdk_aarch64_linux_Nightly_testList_1/67/

I won't keep reporting the failures.

@hzongaro
Copy link
Member

hzongaro commented Oct 18, 2023 •
edited
Loading

In a grinder run with -Xjit:verbose={osr*},vlog=vlog.txt,{*VarHandleBaseTest.bind*}(traceEscapeAnalysis,log=varhandlebind.ea.log), I reproduced the problem, and I've figured out what's going wrong.

From aqa-tests/TKG/output_16974942813774/jdk_lang_1/work/java/lang/invoke/VarHandles/VarHandleTestMethodHandleAccessLong/vlog.txt.20231016.181844.681381

#OSR:  b84e8c00 prepareForOSR at 0000FFFF7D3FB938 (startPC 0000FFFF7D3FB0A8 +2192) at 33:21 numSharingSyms:1 totalSlots:10 vmThread=0000FFFFB84E8C00
#OSRd: B84E8C00   Jitted body:    VarHandleBaseTest.bind(Ljava/lang/invoke/VarHandle;Ljava/lang/invoke/MethodHandle;Ljava/lang/invoke/MethodType;)Ljava/lang/invoke/MethodHandle;
#OSRd: B84E8C00   Inlined method: java/lang/invoke/MethodHandles$Lookup.checkAccess(Ljava/lang/invoke/MethodHandle;Z)V
#OSRd: B84E8C00   osrBuffer=0000FFFF0C097ED8 osrFrame=0000FFFF0C097EE8, osrReturnAddress=0000FFFFB71FB81C osrScratchBuffer=0000FFFF0C098070 osrJittedFrameCopy=0000FFFF0C0980B0
#OSRd: B84E8C00     OSRBuffer: numberOfFrames=3 jitPC=0000FFFF7D3FB938
#OSRd: B84E8C00     OSRFrame: j9method=0000FFFFB82C9480 bytecodePC=454f55f9 numberOfLocals=3 maxStack=7 pendingStackHeight=1 monitorEnterRecords=0000000000000000
#OSRd: B84E8C00       stack  0: 0000FFFF0C008128
#OSRd: B84E8C00       local  2: 0000000000000000
#OSRd: B84E8C00       local  1: 0000FFFFB58AF088
#OSRd: B84E8C00       local  0: 0000FFFF0C008128
#OSRd: B84E8C00   3 mappings
#OSRd: B84E8C00     Skip mapping @2188 <= 2192 with 0 symbols
#OSRd: B84E8C00   Found mapping @9816 > 2192
#OSRd: B84E8C00   Copying 0 symbols
#OSRd: B84E8C00   prepareForOSR returning

#OSR:  b84e8c00 prepareForOSR at 0000FFFF7D3FB938 (startPC 0000FFFF7D3FB0A8 +2192) at 31:28 numSharingSyms:2 totalSlots:7 vmThread=0000FFFFB84E8C00
#OSRd: B84E8C00   Jitted body:    VarHandleBaseTest.bind(Ljava/lang/invoke/VarHandle;Ljava/lang/invoke/MethodHandle;Ljava/lang/invoke/MethodType;)Ljava/lang/invoke/MethodHandle;
#OSRd: B84E8C00   Inlined method: java/lang/invoke/MethodHandles$Lookup.revealDirect(Ljava/lang/invoke/MethodHandle;)Ljava/lang/invoke/MethodHandleInfo;
#OSRd: B84E8C00   osrBuffer=0000FFFF0C097ED8 osrFrame=0000FFFF0C097F70, osrReturnAddress=0000FFFFB71FB81C osrScratchBuffer=0000FFFF0C098070 osrJittedFrameCopy=0000FFFF0C0980B0
#OSRd: B84E8C00     OSRBuffer: numberOfFrames=3 jitPC=0000FFFF7D3FB938
#OSRd: B84E8C00     OSRFrame: j9method=0000FFFFB82C9840 bytecodePC=454f6b14 numberOfLocals=3 maxStack=4 pendingStackHeight=0 monitorEnterRecords=0000000000000000
#OSRd: B84E8C00       local  2: 0000000000000000
#OSRd: B84E8C00       local  1: 0000FFFFB58AF088
#OSRd: B84E8C00       local  0: 0000FFFF0C008128   
#OSRd: B84E8C00   3 mappings
#OSRd: B84E8C00     Skip mapping @2188 <= 2192 with 0 symbols
#OSRd: B84E8C00   Found mapping @9816 > 2192
#OSRd: B84E8C00   Copying 0 symbols
#OSRd: B84E8C00   prepareForOSR returning

#OSR:  b84e8c00 prepareForOSR at 0000FFFF7D3FB938 (startPC 0000FFFF7D3FB0A8 +2192) at -1:1b numSharingSyms:1 totalSlots:11 vmThread=0000FFFFB84E8C00
#OSRd: B84E8C00   Jitted body:    VarHandleBaseTest.bind(Ljava/lang/invoke/VarHandle;Ljava/lang/invoke/MethodHandle;Ljava/lang/invoke/MethodType;)Ljava/lang/invoke/MethodHandle;
#OSRd: B84E8C00   osrBuffer=0000FFFF0C097ED8 osrFrame=0000FFFF0C097FE0, osrReturnAddress=0000FFFFB71FB81C osrScratchBuffer=0000FFFF0C098070 osrJittedFrameCopy=0000FFFF0C0980B0
#OSRd: B84E8C00     OSRBuffer: numberOfFrames=3 jitPC=0000FFFF7D3FB938
#OSRd: B84E8C00     OSRFrame: j9method=0000FFFFB84D8AD8 bytecodePC=765489e3 numberOfLocals=4 maxStack=7 pendingStackHeight=0 monitorEnterRecords=0000000000000000
#OSRd: B84E8C00       local  3: 0000FFFFB58AF088
#OSRd: B84E8C00       local  2: 0000FFFF967494B0
#OSRd: B84E8C00       local  1: 0000FFFFB58AF088
#OSRd: B84E8C00       local  0: 0000FFFF966EA9F0
#OSRd: Created OSR code block and catch block for inlined index -1 in java/lang/invoke/VarHandle$AccessMode.valueOf(Ljava/lang/String;)Ljava/lang/invoke/VarHandle$AccessMode; calling java/lang/invoke/VarHandle$AccessMode.valueOf(Ljava/lang/String;)Ljava/lang/invoke/VarHandle$AccessMode;
#OSRd: B84E8C00   3 mappings
#OSRd: B84E8C00     Skip mapping @2188 <= 2192 with 0 symbols
#OSRd: B84E8C00   Found mapping @9816 > 2192
#OSRd: B84E8C00   Copying 0 symbols
#OSRd: B84E8C00   prepareForOSR returning

Focusing on the prepareForOSR at 33:21 and 31:28, the IL leading up to that point before stack allocation looks like this, in part:

n7630n    BBStart <block_561> (freq 2917) (in loop 561)                                       [    0xfffea36e40b0] bci=[17,4,1970] rc=0 vc=921 vn=792 li=- udi=- nc=0
n2210n    treetop                                                                             [    0xfffea324a280] bci=[12,5,1806] rc=0 vc=921 vn=794 li=- udi=- nc=1
n2209n      new  jitNewObject[#91  helper Method] [flags 0x400 0x0 ] (highWordZero Unsigned X!=0 allocationCanBeRemoved )  [    0xfffea324a230] bci=[12,5,1806] rc=5 vc=921 vn=76 li=- udi=- nc=1 flg=0x4004
n2208n        loadaddr  java/lang/invoke/MethodHandles$Lookup[#639  Static] [flags 0x18307 0x0 ]  [    0xfffea324a1e0] bci=[12,5,1806] rc=1 vc=921 vn=75 li=- udi=- nc=0
n3846n    astore  <temp slot 2>[#801  Auto] [flags 0x7 0x0 ] (X!=0 )                          [    0xfffea338a1e0] bci=[12,5,1806] rc=0 vc=921 vn=76 li=122 udi=37 nc=1 flg=0x4
n2209n      ==>new
  ...
n2299n    BBStart <block_216> (freq 3505) (in loop 561)                                       [    0xfffea324be50] bci=[31,0,1398] rc=0 vc=921 vn=998 li=- udi=- nc=0
  ...
n3852n    astore  <temp slot 9>[#802  Auto] [flags 0x20000007 0x0 ] (X!=0 )                   [    0xfffea338a3c0] bci=[12,5,1806] rc=0 vc=921 vn=76 li=170 udi=112 nc=1 flg=0x4
n3847n      aload  <temp slot 2>[#801  Auto] [flags 0x7 0x0 ] (X!=0 )                         [    0xfffea338a230] bci=[12,5,1806] rc=1 vc=921 vn=76 li=467 udi=497 nc=0 flg=0x4
n3866n    astore  <temp slot 9>[#802  Auto] [flags 0x20000007 0x0 ] (X!=0 )                   [    0xfffea338a820] bci=[30,0,2332] rc=0 vc=921 vn=76 li=171 udi=113 nc=1 flg=0x4
n3856n      aload  <temp slot 9>[#802  Auto] [flags 0x20000007 0x0 ] (X!=0 )                  [    0xfffea338a500] bci=[30,0,2332] rc=1 vc=921 vn=76 li=468 udi=498 nc=0 flg=0x4
n42n      treetop                                                                             [    0xfffea3005150] bci=[-1,23,266] rc=0 vc=921 vn=1001 li=- udi=- nc=1
n3871n      aload  <temp slot 9>[#802  Auto] [flags 0x20000007 0x0 ] (X!=0 )                  [    0xfffea338a9b0] bci=[-1,23,266] rc=3 vc=921 vn=76 li=469 udi=499 nc=0 flg=0x4
  ...
n5008n    astore  <temp slot 9>[#943  Auto] [flags 0x20000007 0x0 ] (X!=0 privatizedInlinerArg )  [    0xfffea34d0d20] bci=[-1,23,266] rc=0 vc=921 vn=76 li=173 udi=115 nc=1 flg=0x2004
n3871n      ==>aload

  ...
n4026n    BBStart <block_305> (freq 0) (cold) (in loop 561)                                   [    0xfffea338da20] bci=[31,1,1398] rc=0 vc=921 vn=1590 li=- udi=- nc=0
n4057n    treetop                                                                             [    0xfffea338e3d0] bci=[31,0,1398] rc=0 vc=921 vn=1592 li=- udi=- nc=1
n4056n      call  prepareForOSR[#55  helper Method] [flags 0x400 0x0 ] ()                     [    0xfffea338e380] bci=[31,0,1398] rc=1 vc=921 vn=1591 li=- udi=- nc=26 flg=0x20
  ...
n4047n        aload  <temp slot 9>[#943  Auto] [flags 0x20000007 0x0 ] (X!=0 )                [    0xfffea338e0b0] bci=[31,0,1398] rc=1 vc=921 vn=76 li=- udi=730 nc=0 flg=0x4
n4048n        iconst 369 (X!=0 X>=0 )                                                         [    0xfffea338e100] bci=[31,0,1398] rc=1 vc=921 vn=495 li=- udi=- nc=0 flg=0x104
n4049n        iconst -1 (X!=0 X<=0 )                                                          [    0xfffea338e150] bci=[31,0,1398] rc=1 vc=921 vn=25 li=- udi=- nc=0 flg=0x204
n4050n        aload  <temp slot 10>[#944  Auto] [flags 0x20000007 0x0 ]                       [    0xfffea338e1a0] bci=[31,0,1398] rc=1 vc=921 vn=2 li=- udi=731 nc=0
n4051n        iconst 370 (X!=0 X>=0 )                                                         [    0xfffea338e1f0] bci=[31,0,1398] rc=1 vc=921 vn=494 li=- udi=- nc=0 flg=0x104
n4052n        iconst -1 (X!=0 X<=0 )                                                          [    0xfffea338e240] bci=[31,0,1398] rc=1 vc=921 vn=25 li=- udi=- nc=0 flg=0x204
n4053n        aconst NULL (X==0 )                                                             [    0xfffea338e290] bci=[31,0,1398] rc=1 vc=921 vn=59 li=- udi=- nc=0 flg=0x2
n4054n        iconst 842 (X!=0 X>=0 )                                                         [    0xfffea338e2e0] bci=[31,0,1398] rc=1 vc=921 vn=493 li=- udi=- nc=0 flg=0x104
n4055n        iconst -1 (X!=0 X<=0 )                                                          [    0xfffea338e330] bci=[31,0,1398] rc=1 vc=921 vn=25 li=- udi=- nc=0 flg=0x204

  ...

n4191n    BBStart <block_288> (freq 0) (cold) (in loop 561)                                   [    0xfffea33f0dc0] bci=[33,24,363] rc=0 vc=921 vn=1604 li=- udi=- nc=0
n4222n    treetop                                                                             [    0xfffea33f1770] bci=[33,0,357] rc=0 vc=921 vn=1606 li=- udi=- nc=1
n4221n      call  prepareForOSR[#55  helper Method] [flags 0x400 0x0 ] ()                     [    0xfffea33f1720] bci=[33,0,357] rc=1 vc=921 vn=1605 li=- udi=- nc=26 flg=0x20
n4195n        loadaddr  vmThread[#878  MethodMeta] [flags 0x200 0x0 ]                         [    0xfffea33f0f00] bci=[33,0,357] rc=1 vc=921 vn=521 li=- udi=- nc=0
n4196n        iconst 33 (X!=0 X>=0 )                                                          [    0xfffea33f0f50] bci=[33,0,357] rc=1 vc=921 vn=520 li=- udi=- nc=0 flg=0x104
 ...
 n4212n        aload  <temp slot 9>[#943  Auto] [flags 0x20000007 0x0 ] (X!=0 )                [    0xfffea33f1450] bci=[33,0,357] rc=1 vc=912 vn=- li=- udi=1000 nc=0 flg=0x4
n4213n        iconst 811 (X!=0 X>=0 )                                                         [    0xfffea33f14a0] bci=[33,0,357] rc=1 vc=912 vn=- li=- udi=- nc=0 flg=0x104
n4214n        iconst -1 (X!=0 X<=0 )                                                          [    0xfffea33f14f0] bci=[33,0,357] rc=1 vc=912 vn=- li=- udi=- nc=0 flg=0x204
n4215n        aload  <temp slot 10>[#944  Auto] [flags 0x20000007 0x0 ]                       [    0xfffea33f1540] bci=[33,0,357] rc=1 vc=912 vn=- li=- udi=1001 nc=0
n4216n        iconst 812 (X!=0 X>=0 )                                                         [    0xfffea33f1590] bci=[33,0,357] rc=1 vc=912 vn=- li=- udi=- nc=0 flg=0x104
n4217n        iconst -1 (X!=0 X<=0 )                                                          [    0xfffea33f15e0] bci=[33,0,357] rc=1 vc=912 vn=- li=- udi=- nc=0 flg=0x204

  ...

n7198n    goto --> block_305 BBStart at n4026n                                                [    0xfffea360b9a0] bci=[33,0,357] rc=0 vc=921 vn=1607 li=- udi=- nc=0
n4192n    BBEnd </block_288> (cold) =====                                                     [    0xfffea33f0e10] bci=[33,24,363] rc=0 vc=921 vn=1608 li=- udi=- nc=0

n4248n    BBStart <block_291> (freq 6) (in loop 561)                                          [    0xfffea33f1f90] bci=[33,33,371] rc=0 vc=921 vn=1609 li=- udi=- nc=0
n4264n    astore  <pending push temp 1>[#857  Auto] [flags 0x7 0x800 ] (X==0 StoredValueIsIrrelevant )  [    0xfffea33f2490] bci=[33,33,371] rc=0 vc=921 vn=59 li=- udi=310 nc=1 flg=0x20002
n4263n      aconst NULL (X==0 X>=0 X<=0 )                                                     [    0xfffea33f2440] bci=[33,33,371] rc=1 vc=921 vn=59 li=- udi=- nc=0 flg=0x302
n4266n    astore  <pending push temp 2>[#858  Auto] [flags 0x7 0x800 ] (X==0 StoredValueIsIrrelevant )  [    0xfffea33f2530] bci=[33,33,371] rc=0 vc=921 vn=59 li=- udi=311 nc=1 flg=0x20002
n4265n      aconst NULL (X==0 X>=0 X<=0 )                                                     [    0xfffea33f24e0] bci=[33,33,371] rc=1 vc=921 vn=59 li=- udi=- nc=0 flg=0x302
n4268n    astore  <pending push temp 3>[#866  Auto] [flags 0x7 0x800 ] (X==0 StoredValueIsIrrelevant )  [    0xfffea33f25d0] bci=[33,33,371] rc=0 vc=921 vn=59 li=- udi=312 nc=1 flg=0x20002
n4267n      aconst NULL (X==0 X>=0 X<=0 )                                                     [    0xfffea33f2580] bci=[33,33,371] rc=1 vc=921 vn=59 li=- udi=- nc=0 flg=0x302
n4260n    treetop                                                                             [    0xfffea33f2350] bci=[33,33,371] rc=0 vc=921 vn=1611 li=- udi=- nc=1
n4259n      call  jitInduceOSRAtCurrentPC[#89  helper Method] [flags 0x400 0x0 ]              [    0xfffea33f2300] bci=[33,33,371] rc=1 vc=921 vn=1610 li=- udi=- nc=1
n4273n        aload  <temp slot 10>[#944  Auto] [flags 0x20000007 0x0 ] (X!=0 )               [    0xfffea33f2760] bci=[33,33,371] rc=1 vc=921 vn=2 li=630 udi=746 nc=0 flg=0x4
n8259n    treetop                                                                             [    0xfffea3710550] bci=[33,33,371] rc=0 vc=921 vn=1613 li=- udi=- nc=1
n8249n      call  <eaEscapeHelper>[#310  helper Method] [flags 0x400 0x0 ] ()                 [    0xfffea3710230] bci=[33,33,371] rc=1 vc=921 vn=1612 li=- udi=- nc=9 flg=0x20
n8250n        aload  <parm 0 Ljava/lang/invoke/VarHandle;>[#350  Parm] [flags 0x40000107 0x0 ]  [    0xfffea3710280] bci=[33,33,371] rc=1 vc=921 vn=1 li=- udi=747 nc=0
n8251n        aload  <parm 1 Ljava/lang/invoke/MethodHandle;>[#351  Parm] [flags 0x40000107 0x0 ]  [    0xfffea37102d0] bci=[33,33,371] rc=1 vc=921 vn=2 li=- udi=748 nc=0
n8252n        aload  <parm 2 Ljava/lang/invoke/MethodType;>[#352  Parm] [flags 0x40000107 0x0 ]  [    0xfffea3710320] bci=[33,33,371] rc=1 vc=921 vn=3 li=- udi=749 nc=0
n8253n        aload  this<'this' parm Ljava/lang/invoke/MethodHandles$Lookup;>[#369  Parm] [flags 0x40000107 0x0 ]  [    0xfffea3710370] bci=[33,33,371] rc=1 vc=921 vn=0 li=- udi=750 nc=0
n8254n        aload  target<parm 1 Ljava/lang/invoke/MethodHandle;>[#370  Parm] [flags 0x40000107 0x0 ]  [    0xfffea37103c0] bci=[33,33,371] rc=1 vc=921 vn=0 li=- udi=751 nc=0
n8255n        aload  <temp slot 8>[#633  Auto] (obj1) [flags 0x20000007 0x0 ]                 [    0xfffea3710410] bci=[33,33,371] rc=1 vc=921 vn=58 li=631 udi=752 nc=0
n8256n        aload  this<'this' parm Ljava/lang/invoke/MethodHandles$Lookup;>[#811  Parm] [flags 0x40000107 0x0 ]  [    0xfffea3710460] bci=[33,33,371] rc=1 vc=921 vn=0 li=- udi=753 nc=0
n8257n        aload  handle<parm 1 Ljava/lang/invoke/MethodHandle;>[#812  Parm] [flags 0x40000107 0x0 ]  [    0xfffea37104b0] bci=[33,33,371] rc=1 vc=921 vn=0 li=- udi=754 nc=0
n8258n        aload  <temp slot 11>[#1120  Auto] (obj2) [flags 0x20000007 0x0 ]               [    0xfffea3710500] bci=[33,33,371] rc=1 vc=921 vn=522 li=632 udi=755 nc=0
n4262n    athrow  jitThrowException[#24  helper Method] [flags 0x400 0x0 ] (Unsigned ThrowInsertedByOSR )  [    0xfffea33f23f0] bci=[33,33,371] rc=0 vc=921 vn=1614 li=- udi=- nc=1 flg=0x4000
n4261n      aload  ExceptionMeta[#279  MethodMeta +64] [flags 0x207 0x0 ]                     [    0xfffea33f23a0] bci=[33,33,371] rc=1 vc=921 vn=523 li=- udi=- nc=0
n4249n    BBEnd </block_291> =====                                                            [    0xfffea33f1fe0] bci=[33,33,371] rc=0 vc=921 vn=1615 li=- udi=- nc=0

Notice that the defining sym for #811 in block_288 is #943, and for #369 in block_305 is #943. However, the eaEscapeHelper call that appears after the call to jitInduceOSRAtCurrentPC in block_288 has references to #369 and #811 rather than #943. #943 itself contains a reference to an object that is allocated via a new operation, and ends up being stack allocated by Escape Analysis, with no heapification in the induce block_288 block_291.

n7630n    BBStart <block_561> (freq 2917) (in loop 561)                                       [    0xfffea36e40b0] bci=[17,4,1970] rc=0 vc=921 vn=792 li=- udi=- nc=0
n2210n    treetop                                                                             [    0xfffea324a280] bci=[12,5,1806] rc=0 vc=921 vn=794 li=- udi=- nc=1
n2209n      new  jitNewObject[#91  helper Method] [flags 0x400 0x0 ] (highWordZero Unsigned X!=0 allocationCanBeRemoved )  [    0xfffea324a230] bci=[12,5,1806] rc=5 vc=921 vn=76 li=- udi=- nc=1 flg=0x4004
n2208n        loadaddr  java/lang/invoke/MethodHandles$Lookup[#639  Static] [flags 0x18307 0x0 ]  [    0xfffea324a1e0] bci=[12,5,1806] rc=1 vc=921 vn=75 li=- udi=- nc=0
n3846n    astore  <temp slot 2>[#801  Auto] [flags 0x7 0x0 ] (X!=0 )                          [    0xfffea338a1e0] bci=[12,5,1806] rc=0 vc=921 vn=76 li=122 udi=37 nc=1 flg=0x4
n2209n      ==>new
  ...
n2299n    BBStart <block_216> (freq 3505) (in loop 561)                                       [    0xfffea324be50] bci=[31,0,1398] rc=0 vc=921 vn=998 li=- udi=- nc=0
  ...
n3852n    astore  <temp slot 9>[#802  Auto] [flags 0x20000007 0x0 ] (X!=0 )                   [    0xfffea338a3c0] bci=[12,5,1806] rc=0 vc=921 vn=76 li=170 udi=112 nc=1 flg=0x4
n3847n      aload  <temp slot 2>[#801  Auto] [flags 0x7 0x0 ] (X!=0 )                         [    0xfffea338a230] bci=[12,5,1806] rc=1 vc=921 vn=76 li=467 udi=497 nc=0 flg=0x4
n3866n    astore  <temp slot 9>[#802  Auto] [flags 0x20000007 0x0 ] (X!=0 )                   [    0xfffea338a820] bci=[30,0,2332] rc=0 vc=921 vn=76 li=171 udi=113 nc=1 flg=0x4
n3856n      aload  <temp slot 9>[#802  Auto] [flags 0x20000007 0x0 ] (X!=0 )                  [    0xfffea338a500] bci=[30,0,2332] rc=1 vc=921 vn=76 li=468 udi=498 nc=0 flg=0x4
n42n      treetop                                                                             [    0xfffea3005150] bci=[-1,23,266] rc=0 vc=921 vn=1001 li=- udi=- nc=1
n3871n      aload  <temp slot 9>[#802  Auto] [flags 0x20000007 0x0 ] (X!=0 )                  [    0xfffea338a9b0] bci=[-1,23,266] rc=3 vc=921 vn=76 li=469 udi=499 nc=0 flg=0x4
  ...
n5008n    astore  <temp slot 9>[#943  Auto] [flags 0x20000007 0x0 ] (X!=0 privatizedInlinerArg )  [    0xfffea34d0d20] bci=[-1,23,266] rc=0 vc=921 vn=76 li=173 udi=115 nc=1 flg=0x2004
n3871n      ==>aload

Final candidates
Candidate 0:
   Node = 0000FFFEA338CE90, contiguous = 1, local = 1
   Flags = {LocalAllocation MustBeContiguous ObjectIsReferenced InsideALoop }
   Value numbers = { 204 }
   1 fields:
      0: offset=16  size=8  vectorElem=0  symRef=null good={#937} bad={}
Candidate 1:
   Node = 0000FFFEA324A230, contiguous = 1, local = 1
   Flags = {LocalAllocation MustBeContiguous ObjectIsReferenced InsideALoop }
   Value numbers = { 76 }
   4 fields:
      0: offset=36  size=4  vectorElem=0  symRef=null good={#659} bad={}
      1: offset=24  size=8  vectorElem=0  symRef=null good={#660} bad={}
      2: offset=16  size=8  vectorElem=0  symRef=null good={#661} bad={}
      3: offset=32  size=4  vectorElem=0  symRef=null good={#662} bad={}

Earlier, Escape Analysis claims it's adding a reference to #943 to the eaEscapeHelper call:

insertFakeEscapeForOSR:  definingMap at induceCall n4259n 33:33
# 350:{350}
# 351:{351}
# 352:{352}
# 355:{355}
# 369:{943}
# 370:{944}
# 372:{372}
# 806:{806}
# 810:{810}
# 811:{943}
# 812:{944}
# 817:{817}
# 820:{820}
# 856:{856}
# 857:{857}
# 858:{858}
# 866:{866}
Calling processAutosAndPendingPushes:  At 33:33,  ResolvedMethodSymbol [0000FFFEA33D84F0] and OSRMethodData [0000FFFEA33E3C00]
Calling processSymbolReferences for auto symRefs and pending push symRefs.  deadSymRefs at this point:
{857, 858, 866, 869}
In processSymbolReferences, adding definingSymRef #943 to symRefsToLoad
In processSymbolReferences, adding definingSymRef #944 to symRefsToLoad
Calling processAutosAndPendingPushes:  At 31:40,  ResolvedMethodSymbol [0000FFFEA30716C0] and OSRMethodData [0000FFFEA33D67D0]
Calling processSymbolReferences for auto symRefs and pending push symRefs.  deadSymRefs at this point:
{806, 810, 817, 820, 823, 841, 842}
In processSymbolReferences, adding definingSymRef #943 to symRefsToLoad
In processSymbolReferences, adding definingSymRef #944 to symRefsToLoad
Calling processAutosAndPendingPushes:  At -1:27,  ResolvedMethodSymbol [0000FFFEA30054A0] and OSRMethodData [0000FFFEA3050000]
Calling processSymbolReferences for auto symRefs and pending push symRefs.  deadSymRefs at this point:
{355, 362, 372}
In processSymbolReferences, adding definingSymRef #350 to symRefsToLoad
In processSymbolReferences, adding definingSymRef #351 to symRefsToLoad
In processSymbolReferences, adding definingSymRef #352 to symRefsToLoad
In processSymbolReferences, definingSymRef #372 - isAuto == 1; isParm == 0; dead == 1 - not added to symRefsToLoad
In processSymbolReferences, adding symRef #633 to symRefsToLoad
In processSymbolReferences, adding symRef #1120 to symRefsToLoad
In processSymbolReferences, definingSymRef #355 - isAuto == 1; isParm == 0; dead == 1 - not added to symRefsToLoad
In processSymbolReferences, symRef #362 is dead - not added to symRefsToLoad

It turns out that code in TR_EscapeAnalysisTools::processSymbolReferences that should be adding the defining sym ref to the BitVector of sym refs to include on the call to eaEscapeHelper was adding the original sym ref instead. I introduced this bug earlier this year in commit eddbd1b.

@hzongaro hzongaro mentioned this issue Oct 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hzongaro hzongaro

Labels
blocker comp:jit comp:vm test failure
Projects
None yet
Milestone
Release 0.43 (Java 8, 11, 17, 21) Jan...
Development

Successfully merging a pull request may close this issue.

Use defining symrefs from defining map for <eaEscapeHelper> call hzongaro/openj9
3 participants
@tajila @pshipton @hzongaro