[win] slow WorkingSetManager.addProject

[jukzi]

While creating eclipse platform workspace ~ 40 of ~ 50 sec are burned in RepositoryPredicateImpl.getRepoDirAbsolutePath() on my computer

Stack:

[merks]

Which OS?

[jukzi]

Windows 10

[merks]

I suppose it's walking up the parent folders and not finding a .git folder anywhere but at some point is maybe hitting a network drive that is very slow:

oomph/plugins/org.eclipse.oomph.predicates/src/org/eclipse/oomph/predicates/impl/RepositoryPredicateImpl.java

Lines 251 to 271 in 7a6ea7b

	private Path getRepoDirAbsolutePath(IProject project)
	{
	if (project != null)
	{
	RepositoryProvider provider = RepositoryProvider.getProvider(project);
	if (provider == null)
	{
	URI locationURI = project.getLocationURI();
	if (locationURI != null && "file".equals(locationURI.getScheme())) //$NON-NLS-1$
	{
	org.eclipse.emf.common.util.URI emfURI = org.eclipse.emf.common.util.URI.createURI(locationURI.toString());
	for (File parent = new File(emfURI.toFileString()); parent != null && parent.isDirectory(); parent = parent.getParentFile())
	{
	File gitFolder = new File(parent, ".git"); //$NON-NLS-1$
	if (new File(gitFolder, "index").exists()) //$NON-NLS-1$
	{
	return parent.toPath();
	}
	}
	}
	}

I'm not sure what to do about. I don't even expect any of the folders not have providers in the first place...

[jukzi]

According to the stacktrace its not a network but only the windows filesystem. i have not analysed it but typically such timings only appear if the same files are queried over and over - for example for every project do the same query again. (multiple projects in the repo)

[merks]

That's good to know. Yes, I'm sure it's being done over and over again for each project, so some "transient" caching would likely help...