Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variables are shown in random order #16

Open
jukzi opened this issue Aug 15, 2023 · 6 comments
Open

Variables are shown in random order #16

jukzi opened this issue Aug 15, 2023 · 6 comments

Comments

@jukzi
Copy link

jukzi commented Aug 15, 2023

every once i start Oomph the Variables are shown in a different order.
Example1:
image
Example2:
image

Can even be triggered by using "back" and "next" buttons.
That's irritating.

@merks
Copy link
Contributor

merks commented Aug 18, 2023

The only way I've been able to get the second order is to check and uncheck "Show all variables".

It looks to me like the logic for the order is deterministic. There is some reordering involved though to keep "related" variables closer together and to keep impactful variables near the beginning. You're really sure this really comes up randomly differently initially or that it randomly changes for next/back navigation? I really cannot reproduce that, and not for lack of trying...

Note too that I assume you get to this with the platform configuration, but after a dozen clicks on that all with the same "picture number one", I'm not convinced there is any randomness. Please double check your steps to reproduce the issue.

@jukzi
Copy link
Author

jukzi commented Aug 18, 2023

I have seen the different orders multiple times in the last year. I reported this when i was able to reproduce it by back/next. Typically i go back+back, uncheck Bundle pool, and go next+next.
Today i could not reproduce it with back/next either. Seems to be only sometimes random

@SVNKoch
Copy link

SVNKoch commented Sep 13, 2023

I can't remember having seen them switch between a Back > Next page switch. But I can confirm the order changing between restarts and selecting them same product and projects.

@merks
Copy link
Contributor

merks commented Sep 13, 2023

If I cannot reproduce it then I cannot fix it.

@mmosconi1
Copy link

The order of variables in the dialog seems to depend on the order of their usage in the setup.
That's why we try to get a defined order by introducing an internal variable referencing all user variables in the desired order and put this one first in the setup.
But even with this approach, the variables that are used in filters (bold label) are automatically placed. The same for variables inside conditional containers.

@merks
Copy link
Contributor

merks commented Oct 12, 2023

Yes, the ones used in filters are intentionally moved to the front because they affect which tasks are collected and that in turn can affect which other variables are used and hence prompted/displayed...

If someone can provide something or some steps where the order changes or appears different "each time" I can investigate. But if I can't reproduce anything like it, I'm at a loss to make progress on it. Sorry. 😱

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants