-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 404 page's styling #238
Conversation
|
This is still draft, because I need to test as a deployment ftm because on local mode it does not show up the custom 404. The problem so far is that the |
Bah, it seems I cannot test it really on a preview server. The 404 page is a result of the HTTP server, which redirects to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to break the GitHub PR preview:
https://eclipse-langium.github.io/langium-previews/pr-previews/pr-238/docs/
True. We need to set the correct base url before we are building. Otherwise it would be EDIT: @msujew I tried adding the base URL in the GH Action. But for some reason it seems to use the workflow file from main, not from the branch. Is there any way to test this locally? Do you know something? |
I've peeked at this too and it feels like hugo isn't responding to a myriad of ways to set a custom 404. The usual locations in layout, static, or even modifying the theme don't seem to have effect (notably the theme's own 404 isn't applied as expected). There can be a few reasons for this based on how we've customized the app, but we're also using an older version from about 3 years ago. I'm not sure how easily we could upgrade, but it might be worth checking if some newer version of hugo makes it easier to resolve this. |
I am closing this PR. No idea how to check this, without breaking something. |
Fixes #236