How does Aries Spy Fly get included into JDTLS?

[guw]

I am a bit puzzled. I checked the latest vscode-java extension. When I execute npx gulp download_server it fetches the latest server and unpacks it. This does contain the Apache Spy Fly bundles as well as ASM.

However, when I look at the latest product definition it shouldn't be included. The product is based on plug-ins and does not list them. Is there something I am missing?

The reason I am asking is that two things are missing for Logback logging to work properly in SLF4J. Currently, jakarta.servlet-api is needed and start levels need to be added for Aris Spy Fly as well as Logback (see here, here and here). I was thinking of preparing a patch but wondering how this is included into the product.

[snjeza]

The issue has been introduced by fixing #2825.
Java LS logging doesn't work. #2831 fixes it.

[guw]

Thanks. But still puzzling how Aries was available in the JDTLS binary I looked at. autoIncludeRequirements="true" shouldn't work because AFAIK nothing requires it directly. Unless p2 really resolves it because of the extra requirements (capabilities). 🤔

[rgrunber]

@snjeza , hold on. Do we really need to include Aries Spy Fly ?

I'm actually noticing some really strange behaviour with it included in autostart when I try to play with the language server via cli.

[snjeza]

Do we really need to include Aries Spy Fly ?

@rgrunber Java LS logging doesn't work without it. m2e uses it too - https://github.com/HannesWell/m2e-core/blob/0e854a7dd2d0afeb2b3d07df64f61919667bc911/products/m2e-ide/m2e-ide.product#L35

I'm actually noticing some really strange behaviour with it included in autostart when I try to play with the language server via cli.

@rgrunber Could you, please, describe the issue?

[rgrunber]

See #2831 (comment) . Basically the language server seems to be receiving an additional newline in its stream, causing it to behave as if it has received improper messages.

[snjeza]

@rgrunber I will check.