Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test0008 and others: empty block comment misunderstood by javac a… #1064

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

robstryker
Copy link

…s block comment

@mickaelistria
Copy link

This doesn't seem to fix test0008 (nor any other test) so far.

@robstryker
Copy link
Author

It seems to fix it locally. Will rebase and see if something is conflicting.

@robstryker
Copy link
Author

< org.eclipse.jdt.core.tests.model.ClasspathTests testExtraAttributes4
827a827
> org.eclipse.jdt.core.tests.model.CompletionContextTests test0008
1310d1309
< org.eclipse.jdt.core.tests.model.CompletionTests18 test005
1317d1315
< org.eclipse.jdt.core.tests.model.CompletionTests18 test014
1375d1372
< org.eclipse.jdt.core.tests.model.CompletionTests18 test485492b

I'm assuming this is a problem with comparing to an active dom-with-javac branch, where someone else has fixed those 4 other tests. Those tests pass for me locally after rebasing.

@mickaelistria
Copy link

Fixes 2, let's merge.
About the diff, I recently faced a similar oddity and found out that the script to get failures needs to be updated to ignore the "FIXED" tests too:

curl -H 'Cache-Control: no-cache' --compressed https://ci.eclipse.org/ls/job/jdt-core-incubator/job/PR-1064/lastSuccessfulBuild/testReport/api/xml | xmllint --xpath '/testResult/suite/case[status != "PASSED" and status != "FIXED"]/*[name() = "className" or name() = "name"]/text()' - | sed 'N; s/\n/ /' - | sort > pr1064.txt

@mickaelistria mickaelistria merged commit 3d3f6fc into eclipse-jdtls:dom-with-javac Dec 19, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants