Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23] Markdown is not rendered when \r and \n are code in unicode #1787

Open
jarthana opened this issue Nov 8, 2024 · 0 comments · May be fixed by #1850
Open

[23] Markdown is not rendered when \r and \n are code in unicode #1787

jarthana opened this issue Nov 8, 2024 · 0 comments · May be fixed by #1850
Assignees
Labels
bug Something isn't working
Milestone

Comments

@jarthana
Copy link
Member

jarthana commented Nov 8, 2024

This was originally raised in 3239
The jdt.core part has been addressed. The UI, where the rendering to HTML happens has to handle the unicode characters to create the correct HTML content.

The markdown comment is this:
/// Unicode in markdown \u000A///\u000D///\u000D\u000A///here

And this is the HTML created by JavadocContentAccess2.getHTMLContent():
Unicode in markdown \u000A/// \u000D/// \u000D\u000A/// here

Javadoc from JDK creates this:

<div class="block"><p>Unicode in markdown</p>
<p>here</p>
</div>
@jjohnstn jjohnstn self-assigned this Dec 12, 2024
@jjohnstn jjohnstn added the bug Something isn't working label Dec 12, 2024
@jjohnstn jjohnstn added this to the 4.35 M1 milestone Dec 12, 2024
jjohnstn added a commit to jjohnstn/eclipse.jdt.ui-1 that referenced this issue Dec 12, 2024
- convert unicode chars in CoreMarkdownAccessImpl.removeDocLineIntros()
- add new test to MarkdownCommentTests
- fixes eclipse-jdt#1787
@jjohnstn jjohnstn linked a pull request Dec 12, 2024 that will close this issue
3 tasks
jjohnstn added a commit to jjohnstn/eclipse.jdt.ui-1 that referenced this issue Dec 14, 2024
- convert unicode chars in CoreMarkdownAccessImpl.removeDocLineIntros()
- add new test to MarkdownCommentTests
- fixes eclipse-jdt#1787
jjohnstn added a commit to jjohnstn/eclipse.jdt.ui-1 that referenced this issue Dec 16, 2024
- convert unicode chars in CoreMarkdownAccessImpl.removeDocLineIntros()
- add new test to MarkdownCommentTests
- fixes eclipse-jdt#1787
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants