-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search in 4.30 sometimes finds nothing #1488
Comments
Anyone from JDT? |
I believe there were some refactorings in the search code, @jukzi : could you please check if they were done in 4.30 time frame? @cdietrich, @LorenzoBettini : could you try to provide stable test case that would fail? Or test setup that would reproduce the problem more reliably as "sometimes"? |
@iloveeclipse Unfortunately that's the real problem: it happens sometimes and in the CI :'( |
I am not aware of any search refactorings in JDT where i was involved. |
@iloveeclipse some more context: in our UI tests we create projects programmatically. Doing that inside or outside a |
Just in case, are you running with this option: If you don't use this option, please add it. It would be at least nice to know when exactly the problems started. Was it really 4.30 or maybe 4.29? If 4.30, was it M1, M2, M3? Beside this, JobManager changes could be related, but they also were done already in 4.29: |
@iloveeclipse I remember I immediately hated that feature in my Eclipse installations, but we never disabled that for tests. Something like this LorenzoBettini/xtext@428c1e6 should disable it globally right? |
I have a very little understanding about maven / tycho / surefire settings and which one need to be touched to get the desired effect. Add an assert in the test for the VM option (system property) to be set & you will see it. |
@iloveeclipse adding that option in I see two occurrences in jdt.core
and
I'd say the second one is "more" standard. I'll try that |
don't waste your time on that - that problem was solved with eclipse-jdt/eclipse.jdt.debug#293 |
Are you sure? That was only for the pure jdt core tests that didn't require launching plugin. If MWE/Xtext require it, the job is scheduled. |
I am sure (but still human error prone). |
@iloveeclipse @jukzi That option seems to do something: eclipse-xtext/xtext#3063 flakes are less, and they usually succeed after the first attempt. It looks like there are still synchronization problems, which shouldn't be there, but at least that job detecting JVM doesn't seem to disturb anymore. |
@LorenzoBettini : thanks. |
@iloveeclipse In any case; it would be really helpful to have some guidelines on how to properly synchronize with jobs of this kind... |
@LorenzoBettini : for search, index state is important, so you could do something like Or more complex example: Lines 4064 to 4090 in 75ade7e
|
@iloveeclipse Thanks! |
Xtexts Xbase content assist uses jdt search to provide proposals for jdt tyes
beginning with 4.30 we see regular test fails in
mwe
eclipse-mwe/mwe#270
here are the trace logs for good and bad testcase
goodcase.txt
badcase.txt
i have no clue how to start investigating
The text was updated successfully, but these errors were encountered: