Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a Findacl.cmake to setup the dependency to libacl #2343

Open
guill-delacourt opened this issue Sep 9, 2024 · 2 comments
Open

Use a Findacl.cmake to setup the dependency to libacl #2343

guill-delacourt opened this issue Sep 9, 2024 · 2 comments
Labels
good first issue Good for newcomers

Comments

@guill-delacourt
Copy link

Brief feature description

The build process of iceoryx could be improved by using find_package to setup the dependency to libacl, allowing to detect if it is installed. Since libacl doesn't provide CMake config scripts, iceoryx could provide a Findacl.cmake instead (and add its directory to its list of CMAKE_MODULE_PATH).

Detailed information

Currently, the build script of iceoryx expects that libacl is installed on the system through the package manager.
While this should be the prefered way to install acl, it's not always possible to do this, notably if the user don't have administrative rights to the system or when cross-compiling iceoryx for a sysroot that should be kept cleared. In that case, the libacl is installed in another directory. When using find_package to setup the dependency, the directory in which libacl is installed can be search with the CMAKE_STAGING_PREFIX or CMAKE_INSTALL_PREFIX. Currently, the directory should be listed though compiler flags.

@elBoberido
Copy link
Member

@guill-delacourt would be great. Can you create a pull request?

@guill-delacourt
Copy link
Author

I don't have a patch ready, nor the greenlight to contribute one. However, if I have to patch iceoryx for something else (I'm thinking of the workaround indicated in the issue #1176 ), this situation could change.

@elBoberido elBoberido added the good first issue Good for newcomers label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants