Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] utils.rs discover_service_using_chariott should be checking if communication kind and reference both match the expected #111

Open
1 task
ladatz opened this issue Mar 28, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@ladatz
Copy link
Contributor

ladatz commented Mar 28, 2024

Description

discover_service_using_chariott in samples/common/src/utils.rs and core/common/src/utils.rs check if communication kind and communication reference match what is expected. There's currently a bug where it throws an error if both are incorrect, but not one or the other.

if service.communication_kind != expected_communication_kind && service.communication_reference != expected_communication_reference { Err(Status::not_found(

Acceptance criteria

  • If either communication kind or communication reference are incorrect, "discover_service_using_chariott" should throw an error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant