[#1869] Fix extraction of trace context from CoAP request

The TracingSupportingHonoResource used a carrier format that is defined by OpenTracing, but not supported by Jaeger. It now uses the standard BINARY format. Signed-off-by: Kai Hudalla <[email protected]>
eclipse-hono · Apr 2, 2020 · 85708cc · 85708cc
1 parent 9238ac4
commit 85708cc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/...ertx-base/src/main/java/org/eclipse/hono/adapter/coap/CoapOptionInjectExtractAdapter.java b/...ertx-base/src/main/java/org/eclipse/hono/adapter/coap/CoapOptionInjectExtractAdapter.java
@@ -23,7 +23,7 @@
 import io.opentracing.propagation.Binary;
 
 /**
- * An adapter for injecting/extracting an OpenTracing span context to/from a CoAP option.
+ * An adapter for injecting/extracting an OpenTracing {@code SpanContext} to/from a CoAP option.
  * <p>
  * The option number being used to hold the context is {@link #OPTION_TRACE_CONTEXT}.
  *

diff --git a/...vertx-base/src/main/java/org/eclipse/hono/adapter/coap/TracingSupportingHonoResource.java b/...vertx-base/src/main/java/org/eclipse/hono/adapter/coap/TracingSupportingHonoResource.java
@@ -78,7 +78,7 @@ public Resource getChild(final String name) {
     }
 
     private SpanContext extractSpanContextFromRequest(final OptionSet requestOptions) {
-        return tracer.extract(Format.Builtin.BINARY_EXTRACT, new CoapOptionInjectExtractAdapter(requestOptions));
+        return tracer.extract(Format.Builtin.BINARY, new CoapOptionInjectExtractAdapter(requestOptions));
     }
 
     private Span newSpan(final Exchange exchange) {