Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compaction.connectedComponents does not respect edge labels #953

Closed
soerendomroes opened this issue Aug 16, 2023 · 3 comments
Closed

compaction.connectedComponents does not respect edge labels #953

soerendomroes opened this issue Aug 16, 2023 · 3 comments
Labels
alg-layered Affects the ELK Layered algorithm. bug Erroneous behaviour.

Comments

@soerendomroes
Copy link
Contributor

soerendomroes commented Aug 16, 2023

This model

node main_x {
  elk.direction: RIGHT
  compaction.connectedComponents: true
  port p0
  node main_x_src {
    port p1
  }
  edge e0: main_x_src.p1 -> p0 {
    label "0"
  }
}

draws the label outside the drawing.

This model

node main_x {
  elk.direction: RIGHT
  compaction.connectedComponents: true
  portConstraints: FIXED_POS
  port p0
  node main_x_src {
    port p1
  }
  edge e0: main_x_src.p1 -> p0 {
    label "0"
  }
}

somehow does not since the fixed port position seems to however rescue it.

It seems that connected components compaction does somehow disrespect the edge label.

@soerendomroes soerendomroes added bug Erroneous behaviour. alg-layered Affects the ELK Layered algorithm. labels Aug 16, 2023
@soerendomroes soerendomroes added this to the Release 0.9.0 milestone Aug 16, 2023
@soerendomroes soerendomroes changed the title compaction.connectedComponents does not respect labels compaction.connectedComponents does not respect edge labels Aug 16, 2023
@soerendomroes
Copy link
Contributor Author

lf-issue1624-bad
lf-issue1624-good

@soerendomroes
Copy link
Contributor Author

@Eddykasp I have a feeling you fixed this for the tapestry, right?

@Eddykasp
Copy link
Contributor

#1081

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alg-layered Affects the ELK Layered algorithm. bug Erroneous behaviour.
Projects
None yet
Development

No branches or pull requests

2 participants