Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use org.eclipse.cdt.debug.ui.debugging context bindings for Visualizer and Executables Views. #919

Merged

Conversation

raghucssit
Copy link
Contributor

Similar to Memory View and Debug Console View, We can use org.eclipse.cdt.debug.ui.debugging for Visualizer and Executables Views

see #918

@jonahgraham
Copy link
Member

Thanks @raghucssit - I'll merge once CI is successful.

@jonahgraham
Copy link
Member

Thanks @raghucssit - I'll merge once CI is successful.

Or someone else can merge if they see it checked. Note that as this touches debug components, it may run some known failing debug tests - see #816

Copy link
Member

@jonahgraham jonahgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build failed because visualizer needs a version bump:

From the log:

The following bundles are missing a service segment version bump:
  - org.eclipse.cdt.visualizer.ui
Please bump service segment by 100 if this change is intended for the main
branch by updating the Bundle-Version: in the MANIFEST.MF of the failing bundles.
See: https://github.com/eclipse-platform/eclipse.platform/blob/master/docs/VersionNumbering.md#when-to-change-the-service-segment

and Executables Views.

Similar to Memory View and Debug Console View, We can use
org.eclipse.cdt.debug.ui.debugging for Visualizer and Executables Views

see eclipse-cdt#918
@raghucssit raghucssit force-pushed the visual_exec_views_cdt_binding_918 branch from 8f79de9 to 477a44b Compare October 19, 2024 15:16
@raghucssit
Copy link
Contributor Author

Build failed because visualizer needs a version bump:

From the log:

The following bundles are missing a service segment version bump:
  - org.eclipse.cdt.visualizer.ui
Please bump service segment by 100 if this change is intended for the main
branch by updating the Bundle-Version: in the MANIFEST.MF of the failing bundles.
See: https://github.com/eclipse-platform/eclipse.platform/blob/master/docs/VersionNumbering.md#when-to-change-the-service-segment

Version bump done.

@akurtakov
Copy link
Contributor

@HannesWell created a bot that does that automatically for platform. Maybe you would like to adapt it for cdt too. https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/blob/master/.github/workflows/checkVersions.yml

@raghucssit
Copy link
Contributor Author

@jonahgraham I have fixed all the review comments. I see known test failures. Otherwise build is good.
Please merge it once you find it good.

@jonahgraham jonahgraham merged commit be92da8 into eclipse-cdt:main Oct 22, 2024
3 of 4 checks passed
@jonahgraham
Copy link
Member

Thanks @raghucssit for this contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants