-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use org.eclipse.cdt.debug.ui.debugging context bindings for Visualizer and Executables Views. #919
Use org.eclipse.cdt.debug.ui.debugging context bindings for Visualizer and Executables Views. #919
Conversation
Thanks @raghucssit - I'll merge once CI is successful. |
Or someone else can merge if they see it checked. Note that as this touches debug components, it may run some known failing debug tests - see #816 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build failed because visualizer needs a version bump:
From the log:
The following bundles are missing a service segment version bump:
- org.eclipse.cdt.visualizer.ui
Please bump service segment by 100 if this change is intended for the main
branch by updating the Bundle-Version: in the MANIFEST.MF of the failing bundles.
See: https://github.com/eclipse-platform/eclipse.platform/blob/master/docs/VersionNumbering.md#when-to-change-the-service-segment
and Executables Views. Similar to Memory View and Debug Console View, We can use org.eclipse.cdt.debug.ui.debugging for Visualizer and Executables Views see eclipse-cdt#918
8f79de9
to
477a44b
Compare
Version bump done. |
@HannesWell created a bot that does that automatically for platform. Maybe you would like to adapt it for cdt too. https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/blob/master/.github/workflows/checkVersions.yml |
@jonahgraham I have fixed all the review comments. I see known test failures. Otherwise build is good. |
Thanks @raghucssit for this contribution. |
Similar to Memory View and Debug Console View, We can use org.eclipse.cdt.debug.ui.debugging for Visualizer and Executables Views
see #918