Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect address (pc) resolution in DisassembleRequest #340

Open
asimgunes opened this issue Nov 18, 2024 · 0 comments
Open

Incorrect address (pc) resolution in DisassembleRequest #340

asimgunes opened this issue Nov 18, 2024 · 0 comments

Comments

@asimgunes
Copy link
Contributor

During the debug session, when user navigates and opens the Disassembly View in the VSCode, the Disassembly View focuses on an incorrect line when it is compared program counter (pc) register as shown above:

image

After a review, I found that the current implementation of the disassembleRequest method at the GDBDebugSessionBase class are not handling the instructionOffset parameters. It seems the disassembleRequest implementation requires to be updated to match the DAP reference.
https://microsoft.github.io/debug-adapter-protocol/specification#Requests_Disassemble

@jonahgraham and I already discussed the issue previously, planning to propose an update to solve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant