-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connection profile details saved in rptdesign file #1922
Comments
BTW this (unintented and superfluous saving of the property bindings) also happens if the data source is referenced from a library. |
The idea of the connection profile is not to remove an existing connection from the BIRT-report if the connection-profile is used. In some of our production plattforms we have up to 5 system stages (development, test, prelife, producton, sandbox). |
Ok, i understand the workaround, and while using dummy values might seem like a functional solution, it's not ideal. When you enable a connection profile, you lose the ability to modify the local connection of the report. If the intention behind the local connection is to serve as a fallback in case no connection profile is available, it should remain editable. Now, consider this: if you're storing your report design in a GitHub repository (and it's well known that storing sensitive information there is unsafe), then the local connection details of the report could pose a security risk. This information could unintentionally fall into the wrong hands. Not even the local connection of the report for the development should end up there, you can just use a connection profile for all cases. From a security perspective, connection details should never be saved directly within the report design. One more thing. If you edit the connection profile directly in the xml file and reload the design, the details in the BIRT JDBC Data Source window will be the ones from the connection profile xml, thus hiding the actual local connection details of the report design. And it will save that data in the the report design file, overwriting the initial details that we presumed to be a fallback. This sure it's not intended behavior. |
+1 This is not quite the same as using a connection profile, but just to demonstrate other ideas of setting up the connection properties dynamically and avoid storing sensitive information in the report, this is what we do (for our JDBC connection): The report uses the builting sample DB for the data source properties. We use a little bit of scripting (Javascript expresisons) in the connection properties. The scripts read the actual connection properties from the environment. |
When using a connection profile the report designer keeps saving these details in the .rptdesign file.
I believe it sould not save them in the .rptdesign as long they are specified in the connection profile file.
report.rptdesign
config.xml
The text was updated successfully, but these errors were encountered: