Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] EbullientTheme Works Gentle Refactoring, Round 2 #115

Open
sigrunixia opened this issue Oct 3, 2024 · 3 comments
Open

[Refactor] EbullientTheme Works Gentle Refactoring, Round 2 #115

sigrunixia opened this issue Oct 3, 2024 · 3 comments

Comments

@sigrunixia
Copy link
Contributor

A lot has changed in the CSS sphere this past year since the first iteration of Publish, in both the APP CSS available and the Publish CSS that is available.

Let's list the current pain points we have, and see if we can address them by the end of the year.

@sigrunixia
Copy link
Contributor Author

sigrunixia commented Oct 3, 2024

Publish

Publish is still too bloated. When I load Javalent's site versus by Arbiters site, it is so much slower. I think I need to be opinionated and remove as much of the excess unneeded styling as possible.

What this means, is that we can move most of the original refactored items back into one file (Yay, no more _app!), and I just maintain a second color file.

This also allows me to build a speedy publish.css for each color combination enabled via style settings.


Phase one of this is completed in #116
Phase 2 will be submitted by Thanksgiving.

@sigrunixia
Copy link
Contributor Author

sigrunixia commented Oct 3, 2024

Checkboxes

In the custom checkboxes thread, we indicated that the checkboxes are a pain point. https://discord.com/channels/686053708261228577/1291112576955977831


We do not yet have a PR for this.

@sigrunixia
Copy link
Contributor Author

sigrunixia commented Oct 6, 2024

We did have a minor issue with Cyan on Dark theme.

Suggested fix.
CleanShot 2024-10-06 at 11 43 00


This is fixed in #116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant