Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support 2076-2-style structures in reassignIds #184

Merged
merged 29 commits into from
Dec 14, 2023
Merged

Support 2076-2-style structures in reassignIds #184

merged 29 commits into from
Dec 14, 2023

Commits on Dec 4, 2023

  1. Reassign IDs to ACFs refd from ATUID 

    This implementation uses the ID value of the ATUID as part of the ACF ID. This means assigned ACF ID's will not necessarily be consecutive, (since some ATUID's may use common definitions ACFs which don't need defining) but they will be unique....
... in most cases. It may throw in ID set methods due to conflicts when 2076-2-style references are mixed with 2076-1 references in the same document. This is because ACF ids mimic the associated ASF and ATF ID's which are assigned in a simple loop with an incrementing counter.
    @firthm01
    firthm01 committed Dec 4, 2023
    Configuration menu
    Copy the full SHA
    1560d72 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2023

  1. Matching ACF/ASF/ATF ID's assigned from next available value via lookup

    @firthm01
    firthm01 committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    cf08039 View commit details
    Browse the repository at this point in the history

  2. Update reassignAllIds comment

    @firthm01
    firthm01 committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    f78a7be View commit details
    Browse the repository at this point in the history

  3. Fix error string typos

    @firthm01
    firthm01 committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    651e123 View commit details
    Browse the repository at this point in the history

  4. Formatting

    @firthm01
    firthm01 committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    adf77f5 View commit details
    Browse the repository at this point in the history

  5. Fix build

    @firthm01
    firthm01 committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    2800169 View commit details
    Browse the repository at this point in the history

  6. Add type def in to assigned IDs

    @firthm01
    firthm01 committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    465bd2d View commit details
    Browse the repository at this point in the history

  7. Throw an error if test data didn't open 

    Don't respond as if the actual comparison failed
    @firthm01
    firthm01 committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    f25631d View commit details
    Browse the repository at this point in the history

  8. Add tests

    @firthm01
    firthm01 committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    0291eef View commit details
    Browse the repository at this point in the history

  9. Reenable reassignIds in ADM Doc tests 

    Not sure why it was commented out. Makes sense to have it in, and it works. Was commented out since "initial commit". Perhaps it wasn't working back then?
    @firthm01
    firthm01 committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    636badf View commit details
    Browse the repository at this point in the history

  10. Formatting

    @firthm01
    firthm01 committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    c087604 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. Update id_assignment.hpp comments

    @firthm01
    firthm01 committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    6ca04b5 View commit details
    Browse the repository at this point in the history

  2. IdReassigner class

    @firthm01
    firthm01 committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    b5cf068 View commit details
    Browse the repository at this point in the history

  3. Constness

    @firthm01
    firthm01 committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    9bd627b View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. Formatting

    @firthm01
    firthm01 committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    8c17432 View commit details
    Browse the repository at this point in the history

  2. Catch running out of IDs

    @firthm01
    firthm01 committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    0c98b6c View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2023

  1. Don't issue an ID unless going to be used 

    Avoid unnecessary incrementation
    @firthm01
    firthm01 committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    2089306 View commit details
    Browse the repository at this point in the history

  2. Formatting

    @firthm01
    firthm01 committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    b643358 View commit details
    Browse the repository at this point in the history

  3. Clarify why 0 initial val

    @firthm01
    firthm01 committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    2859848 View commit details
    Browse the repository at this point in the history

  4. Use emplace over insert

    @firthm01
    firthm01 committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    dd18076 View commit details
    Browse the repository at this point in the history

  5. Move IdReassigner declaration to cpp

    @firthm01
    firthm01 committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    215c74e View commit details
    Browse the repository at this point in the history

  6. reassignAllIds runs outside of ctor

    @firthm01
    firthm01 committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    130b47a View commit details
    Browse the repository at this point in the history

  7. Pass TypeDescriptor by val 

    since just an int anyway
    @firthm01
    firthm01 committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    2beede3 View commit details
    Browse the repository at this point in the history

  8. Limit-check AudioTrackFormatIdCounter

    @firthm01
    firthm01 committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    c57dfb9 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2023

  1. Improve createSimpleObjectShortStructure description

    @firthm01
    firthm01 committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    e99cd5e View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. IdReassigner and IdIssuer descriptions

    @firthm01
    firthm01 committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    0cd8e6c View commit details
    Browse the repository at this point in the history

  2. Describe IdAssigner vs IdReassigner differences

    @firthm01
    firthm01 committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    d5b77e0 View commit details
    Browse the repository at this point in the history

  3. Describe IdAssigner vs IdReassigner differences

    @firthm01
    firthm01 committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    3178fad View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2023

  1. Factor out audioBlockFormat id assignment into function template (#185)

    @rsjbailey
    rsjbailey authored Dec 14, 2023
    Configuration menu
    Copy the full SHA
    61d9c36 View commit details
    Browse the repository at this point in the history