-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: PoC of using a bit of generics and less reflection #172
Draft
Zyko0
wants to merge
12
commits into
ebitengine:main
Choose a base branch
from
Zyko0:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is this plan or only example and hypotetical idea? |
It is just a suggestion to improve performance. There is currently no plans to integrate the ideas in this PR. However that could change in the future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not meant as a merge candidate, just a PoC
Context: ebitengine#purego (discord server)
This is a proof of concept of a generic alternative for
RegisterFunc
as functions ranging fromRegisterFunc0_0
(0 input, 0 output) toRegisterFunc9_1
(9 inputs, 1 output).The goal is to remove a good amount of reflection where it's not needed, but also to remove the need of
reflect.MakeFunc
which returns a heavy function that has plenty of overhead at runtime.There are tests and benchmarks for a few functions of the libc in func_test.go
Difference for
strlen
:Notes:
syscallStack
types are really weird in their implementations, but can be swapped for something else implementing the same interfacepurego.Symbol
should probably be named differently or not be exposed this waynewSyscallStack()
causes an allocation everytime in each runtime function as it escapes, couldn't find a way to remove it so farruntime.KeepAlive
stuff because I couldn't find a proper way to test their needBenchmark results on my machine (Windows)