-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow selection of (alternate) data from maps #86
Comments
The IPCC map is added in the box now. https://app.box.com/files/0/f/11067008935/IPCC |
@potterzot What are the steps? First, I assume we need to make the file and variable information available to the generic R function. In #58 (comment) it looks like there is an R list called "saatchi_agb_num" = list(
ncdir = "",
ncfile = "saatchi.nc",
variable = "agb_1km"
|
I think the below is about right: Step 1 Step 2 biome_default$biomass_ipcc <- res$ Step 3 Nicholas Potter On Fri, Aug 26, 2016 at 10:29 AM, David LeBauer [email protected]
|
I have added a file to Box giving the unit conversions for the maps listed above. https://uofi.box.com/s/y8fsl0obdtzb56wyksgvjin7sc282ice |
@ValentineHerr what are the next steps? Is it just to download the files and add them to the server running the calculator? @potterzot can you help with this? |
@ValentineHerrhttps://github.com/ValentineHerr has loaded the files to the server running the calculator. She is out until next Monday, so I’ll try to help if you have any questions. On Oct 17, 2016, at 3:01 PM, David LeBauer <[email protected]mailto:[email protected]> wrote: @ValentineHerrhttps://github.com/ValentineHerr what are the next steps? Is it just to download the files and add them to the server running the calculator? @potterzothttps://github.com/potterzot can you help with this? — |
A few things on this:
|
sorry for the many mails - I edited then combined all of the previous comments |
@potterzot I just renamed the US Forest biomass file to remove spaces. Others look ok re spaces ... It would be great but low priority to standardize the naming, might help (but be tedious) if all file names indicated source, variables and temporal / spatial domain. On the other hand, where the data are just raw dumps it may make sense to keep the original name just to make it clear that this is straight from the source ... @ValentineHerr could you put a text README in the Box folder that describes the contents of each file? Much of this could probably be copy-pasted from Krista's spreadsheet. |
How urgent is the README file? Is it required to make progress, or just for proper documentation? |
For proper documentation ... not essential but would make development easier. A readme with a link to the spreadsheet if it exists woul suffice. |
@ValentineHerr prepared a README file, which is now in Box. I've also updated the map units file. @potterzot, do you need anything else to finish this issue? |
Reopening this because while the alternative maps are being read in ghgvcR, the user is not currently able to select any alternative maps AFAIK. |
Wanted to recap and get some feedback on this. I've now spent ~2.5 hours figuring out where things stand, what needs to happen, etc... First, it would be easy enough to just add "Anderson-Teixeira and DeLucia (2011)" to the app for sources, which would at least fix the "0" issue, but would not allow dropdown source selection. For implementing source selection:
|
It is not necessary to link the biome default values (i.e., those found here: https://github.com/ebimodeling/ghgvc/blob/master/public/data/maps/biome_defaults.csv) to the original source. This is too complex, and will be thoroughly documented in our current in-prep publication. Please cite this-- "Anderson-Teixeira et al. (in prep)"-- for all of the values default biome values matrix (https://github.com/ebimodeling/ghgvc/blob/master/public/data/maps/biome_defaults.csv) and for the values extracted from the biophysical maps (lines 55-57 in that matrix). For soil carbon, the label should be "Harmonized World Soil Database", and the citation is: Hiederer R, Köchy M (2011) Global soil organic carbon estimates and the harmonized world soil database, Vol. EUR 25225 EN (eds European Commission, Institute for Environment and Sustainability). Publications Office of the European Union, Luxembourg. What we do want is to allow the user to select an alternate value when maps are available. Say the user goes to edit a forest site in the Amazon (T1). The default value should be the one from the default values matrix, so we want them to see "Anderson-Teixeira et al. (in prep)" with a value of 315. The drop-down menu to allow them to select the Saatchi biomass map, and if selected the displayed value should change to whatever the map gives for that location. And so forth with all the maps listed at the top of this issue. |
A few more thoughts that might be helpful: The order of operations for the app is:
I believe the list of "Source" options should be returned from Or if we want to allow selecting maps/sources globally then the edit box should allow a new set of selection boxes that are not parameter specific. |
We will no longer attempt to have this ready for the publication. I'd definitely like to get to it someday. |
We want to be able to load additional data maps, which will provide additional data source options to the user. In the short term, we'd like to get the maps listed below into the calculator. In the longer term, if possible, I'd like to have instructions on how to do this so that someone without web programming skills can load them. If that could already be accomplished, perhaps the best would be to teach @ValentineHerr how to do this, and she can help load the maps we have ready.
The basic idea is that, when the user goes to edit an ecosystem, they have the option of selecting an alternate data layer. For example, as was already implemented in the previous version, a user could go to edit the aboveground biomass attribute (under "initial storage of organic matter") and choose the Saatchi map from the drop-down menu. We would like to retain that setup with the Saatchi map, and add a similar setup with additional maps.
The following maps are ready to be loaded (in Box: gcs>maps to be added to calculator; listed by folder name):
to appear as options for aboveground biomass when selected vegtype = trees:
-IPCC 2006 biomass defaults for forests (@ValentineHerr , I don't see this map in box. Could you please add?)
-"NACP_AGB and C baseline..."
-"NACP-LiDAR AGB...."
-"US forest biomass"
-"Lidar AGB boreal Eurasia"
to appear as option for soil organic carbon (any ecosystem, following same rules as HWSD):
-"Soil organic carbon density"
All units must be converted to Mg/ha. I will provide units conversion.
The text was updated successfully, but these errors were encountered: