Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make code cleaner in anatomogramExperimentTable.js #180

Open
ke4 opened this issue Nov 11, 2024 · 0 comments
Open

Make code cleaner in anatomogramExperimentTable.js #180

ke4 opened this issue Nov 11, 2024 · 0 comments
Labels
improvement Improve/refactor existing code technical debt Technical debt

Comments

@ke4
Copy link
Contributor

ke4 commented Nov 11, 2024

The long and complicated conditional branch could be replaced with a simple JSON file in the atlas-components/packages/atlas-anatomogram-experiment-table/src file.

https://github.com/ebi-gene-expression-group/atlas-components/blame/5e49a70e0ad77477d993ba79237d80ea43437943/packages/atlas-anatomogram-experiment-table/src/anatomogramExperimentTable.js#L92

Please move all the data out from this long conditional statement to a JSON file and use that one in this method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improve/refactor existing code technical debt Technical debt
Projects
None yet
Development

No branches or pull requests

1 participant