Skip to content

Commit

Permalink
build: Simplify a condition
Browse files Browse the repository at this point in the history
The symbol visibility check is a lot simpler, now that we've switched
to Meson's own gnu_symbol_visibility parameter and we're selecting the
public attributes inside the versioning macro header.
  • Loading branch information
ebassi committed Aug 18, 2024
1 parent 3259285 commit d1b91db
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions meson.build
Original file line number Diff line number Diff line change
Expand Up @@ -199,11 +199,9 @@ elif get_option('optimization') in ['2', '3', 's']
endif

extra_args = []
# Detect and set symbol visibility
if get_option('default_library') != 'static'
if host_system == 'windows'
conf.set('DLL_EXPORT', true)
endif
# Export DLL symbols on Windows when building a shared library
if get_option('default_library') != 'static' and host_system == 'windows'
conf.set('DLL_EXPORT', true)
endif

# Optional dependency on GObject
Expand Down

0 comments on commit d1b91db

Please sign in to comment.