Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emit diagnostic when target project does not reference Microsoft.Extensions.Localization.Abstractions #49

Open
earloc opened this issue Dec 3, 2022 · 0 comments
Open

emit diagnostic when target project does not reference Microsoft.Extensions.Localization.Abstractions #49

earloc opened this issue Dec 3, 2022 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone
v0.9

Comments

@earloc
Copy link
Owner

earloc commented Dec 3, 2022

When th package is reference on a project that doesn´t have a dependency on Microsoft.Extensions.Localizatin.Abstractions, the generated code produces compile errors, as IStringLocalizer<T>etc. cannot be found.

This is bad DX.
@earloc earloc added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Dec 3, 2022
@earloc earloc changed the title the source-generator should notify, when the target project does not reference Microsoft.Extensions.Localizatin.Abstractions emit diagnostics when target project does not reference Microsoft.Extensions.Localizatin.Abstractions Dec 27, 2022
@earloc earloc changed the title emit diagnostics when target project does not reference Microsoft.Extensions.Localizatin.Abstractions emit diagnostic when target project does not reference Microsoft.Extensions.Localizatin.Abstractions Dec 27, 2022
@earloc earloc changed the title emit diagnostic when target project does not reference Microsoft.Extensions.Localizatin.Abstractions emit diagnostic when target project does not reference Microsoft.Extensions.Localization.Abstractions Dec 27, 2022
@earloc earloc added this to the v0.9 milestone Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
v0.9
Development

No branches or pull requests
1 participant
@earloc