From 72170df1e3adb3a66386351613c1b2a86d686acd Mon Sep 17 00:00:00 2001 From: d <d@js-MacBook-Pro.local> Date: Sun, 24 Mar 2024 00:18:32 +0100 Subject: [PATCH] codefactor.io cleaning --- src/aboutdialog.h | 1 - src/awarddxmarathon.h | 1 - src/awards.h | 1 - src/awardswidget.h | 5 ---- src/charts/statsfieldperbandwidget.cpp | 1 - src/charts/statsqsosperyearbarchartwidget.cpp | 1 - src/dataproxy_sqlite.h | 1 + src/downloadcty.h | 2 -- src/dxccstatuswidget.h | 3 --- src/elogclublog.cpp | 26 ------------------- src/elogclublog.h | 1 - src/elogqrzlog.h | 1 - src/eqslutilities.h | 1 - src/fileawardmanager.h | 1 - src/filemanager.h | 2 -- src/hamlibclass.h | 3 --- src/infowidget.h | 1 - src/klogdefinitions.h | 7 +---- src/locator.h | 4 --- src/logmodel.h | 1 - src/logwindow.h | 1 - src/lotwutilities.cpp | 1 - src/lotwutilities.h | 1 - src/mainwindow.h | 1 - src/searchmodel.h | 1 - src/searchwidget.h | 3 --- src/searchwindow.h | 1 - src/setuppages/setuppagecolors.h | 1 - src/setuppages/setuppageelog.h | 3 +-- src/setuppages/setuppagelogview.h | 1 - src/setuppages/setuppagesats.cpp | 12 +-------- src/setuppages/setuppagesatsnew.cpp | 5 ---- src/setuppages/setuppagesubdivisions.cpp | 10 +------ src/showerrordialog.h | 1 - src/softwareupdate.h | 1 - src/softwareupdatedialog.h | 1 - src/startwizard.cpp | 2 -- src/statisticswidget.h | 10 +++---- src/tipsdialog.h | 2 -- src/udpserver.h | 2 -- src/updatesettings.h | 1 - src/widgets/adiflotwexportwidget.h | 2 -- src/widgets/map/mapwidget.h | 1 - src/widgets/map/mapwindowwidget.h | 1 - src/widgets/onlinemessagewidget.cpp | 8 +----- src/widgets/onlinemessagewidget.h | 1 - src/widgets/showadifimportwidget.h | 1 - .../tst_mainqsoentrywidget.cpp | 15 +++-------- .../tst_mainwindowsattab.cpp | 15 +++-------- 49 files changed, 15 insertions(+), 154 deletions(-) diff --git a/src/aboutdialog.h b/src/aboutdialog.h index 12c34130..ec111913 100644 --- a/src/aboutdialog.h +++ b/src/aboutdialog.h @@ -45,7 +45,6 @@ class AboutDialog : public QDialog private: QTabWidget *tabw; QWidget *tab1, *tab2, *tab3, *tab4; - }; diff --git a/src/awarddxmarathon.h b/src/awarddxmarathon.h index 4e9a570b..f8cddc6d 100644 --- a/src/awarddxmarathon.h +++ b/src/awarddxmarathon.h @@ -42,7 +42,6 @@ class DXMarathon private: DataProxy_SQLite *dataProxy; - }; #endif // AWARDDXMARATHON_H diff --git a/src/awards.h b/src/awards.h index b6002dd3..06cac907 100644 --- a/src/awards.h +++ b/src/awards.h @@ -167,6 +167,5 @@ class Awards : public QObject { signals: void queryError(QString functionFailed, QString errorCodeS, QString nativeError, QString failedQuery); // To alert about any failed query execution void awardDXCCUpdated(); - }; #endif // AWARDS_H diff --git a/src/awardswidget.h b/src/awardswidget.h index 54bcc135..0f59ee85 100644 --- a/src/awardswidget.h +++ b/src/awardswidget.h @@ -48,14 +48,12 @@ class AwardsWidget : public QWidget void setYear(const int _year); void fillOperatingYears(); void showAwards(); - void clear(); private slots: void slotRecalculateAwardsButtonClicked(); void slotOperatingYearComboBoxChanged(); - signals: //void actionQSODoubleClicked(const int _qsoid); void debugLog (QString _func, QString _msg, DebugLogLevel _level); @@ -64,7 +62,6 @@ private slots: void requireCurrentLogSignal(); void requireCurrentYearSignal(); - private: void createUI(); void setToolTips(); @@ -89,8 +86,6 @@ private slots: DebugLogLevel logLevel; Awards *awards; - - }; #endif // AWARDSWIDGET_H diff --git a/src/charts/statsfieldperbandwidget.cpp b/src/charts/statsfieldperbandwidget.cpp index 03b7e82c..d0e2b3dd 100644 --- a/src/charts/statsfieldperbandwidget.cpp +++ b/src/charts/statsfieldperbandwidget.cpp @@ -77,7 +77,6 @@ void StatsFieldPerBandWidget::createUI() setLayout(layout); connect(modeComboBox, SIGNAL(currentTextChanged(QString)), this, SLOT(slotModeComboBoxChanged() ) ) ; - } void StatsFieldPerBandWidget::prepareChart(const int _log) diff --git a/src/charts/statsqsosperyearbarchartwidget.cpp b/src/charts/statsqsosperyearbarchartwidget.cpp index 9772a3bf..a976b89c 100644 --- a/src/charts/statsqsosperyearbarchartwidget.cpp +++ b/src/charts/statsqsosperyearbarchartwidget.cpp @@ -46,7 +46,6 @@ StatsQSOsPerYearBarChartWidget::~StatsQSOsPerYearBarChartWidget() void StatsQSOsPerYearBarChartWidget::createUI() { - chartView->setRenderHint(QPainter::Antialiasing); QVBoxLayout *graphLayout = new QVBoxLayout; diff --git a/src/dataproxy_sqlite.h b/src/dataproxy_sqlite.h index 3aa7041c..a07b0638 100644 --- a/src/dataproxy_sqlite.h +++ b/src/dataproxy_sqlite.h @@ -48,6 +48,7 @@ enum class DataProxy_SQLite : public QObject { Q_OBJECT + public: DataProxy_SQLite(const QString &_parentFunction, const QString &_softVersion="0.0"); ~DataProxy_SQLite(); diff --git a/src/downloadcty.h b/src/downloadcty.h index 88e61230..42c65027 100644 --- a/src/downloadcty.h +++ b/src/downloadcty.h @@ -78,7 +78,5 @@ private slots: void actionShowProgres(qint64 received, qint64 total); void actionError(const int _i); void downloadStopped(); - - }; #endif // DOWNLOADCTY_H diff --git a/src/dxccstatuswidget.h b/src/dxccstatuswidget.h index a704dc9a..fb7acc7d 100644 --- a/src/dxccstatuswidget.h +++ b/src/dxccstatuswidget.h @@ -78,7 +78,6 @@ private slots: // void showMenuRightButtonFromLogCreateActions(); // void righButtonFromLogMenu(const int trow); - QTableWidget *dxccView; Awards *awards; World *world; @@ -90,7 +89,6 @@ private slots: QPushButton *refreshButton; //QCheckBox *showAllLogsButton; - int numberOfColumns; // Columns will be number Of Bands + 2 (Id + Name) QStringList bandNames, validBands; int logNumber, tempLog; // log in use in the log / log to be used in the widget @@ -98,7 +96,6 @@ private slots: QAction *showDXCCWikipediaAct; int currentLog; - }; #endif // DXCCSTATUSWIDGET_H diff --git a/src/elogclublog.cpp b/src/elogclublog.cpp index 542098c0..a9320430 100644 --- a/src/elogclublog.cpp +++ b/src/elogclublog.cpp @@ -202,24 +202,8 @@ void eLogClubLog::slotErrorManagement(QNetworkReply::NetworkError networkError) { //qDebug()<< "eLogClubLog::slotErrorManagement: " << QString::number(networkError); result = networkError; - - /*if (result == QNetworkReply::NoError) - { - } - else - if (result == QNetworkReply::HostNotFoundError) - { - //qDebug()<< "eLogClubLog::slotErrorManagement: Host not found"; - } - else - { - //qDebug()<< "eLogClubLog::slotErrorManagement: ERROR!"; - } - */ - //actionError(result); } - int eLogClubLog::sendQSO(QStringList _qso) { //qDebug() << "eLogClubLog::sendQSO: " << email << "/" << pass << "/" << api ; @@ -325,13 +309,11 @@ int eLogClubLog::sendDataParams(const QString &_clublogCall, const QUrlQuery &_p params.addQueryItem("api",api); } - postData = params.query(QUrl::FullyEncoded).toUtf8(); QNetworkRequest request(serviceUrl); request.setHeader(QNetworkRequest::ContentTypeHeader, "application/x-www-form-urlencoded"); - //qDebug() << Q_FUNC_INFO << ": " << postData; manager->post(request, postData); //qDebug()<< Q_FUNC_INFO << ": - END"; @@ -470,7 +452,6 @@ NOTES qso = qso + "<FREQ:" + QString::number((_q.at(9)).length()) + ">" + _q.at(9) + " "; } - //qDebug()<< "eLogClubLog::getClubLogAdif: 90" ; qso = qso + "<QSL_RCVD:" + QString::number((_q.at(10)).length()) + ">" + _q.at(10) + " "; //qDebug()<< "eLogClubLog::getClubLogAdif: 100" ; @@ -483,7 +464,6 @@ NOTES qso = qso + "<DXCC:" + QString::number((_q.at(13)).length()) + ">" + _q.at(13) + " "; } - //qDebug()<< "eLogClubLog::getClubLogAdif: 130'" ; if ((_q.at(14)).toInt()> 0) { @@ -508,8 +488,6 @@ void eLogClubLog::setDefaultCallsign(const QString &_defaultStationCallsign) stationCallsign = _defaultStationCallsign; } - - int eLogClubLog::deleteQSO(QStringList _qso) { //qDebug()<< "eLogClubLog::deleteQSO: length = " << QString::number(_qso.length()); @@ -535,7 +513,6 @@ int eLogClubLog::deleteQSO(QStringList _qso) tempCall = stationCallsign; } - dxcall = _qso.at(5); QDateTime dateTime; dateTime.setDate(QDate::fromString(_qso.at(1), "yyyyMMdd")); @@ -570,9 +547,7 @@ int eLogClubLog::deleteQSO(QStringList _qso) //params.addQueryItem("adif",qso); uploadingFile = false; return sendDataParams(tempCall, params, false); - //return sendData(qso); - } QString eLogClubLog::prepareToTranslate(const QString &_m) @@ -713,7 +688,6 @@ void eLogClubLog::sendLogFile(const QString &_file, QList<int> _qso, bool _overw if (file->open(QIODevice::ReadOnly)) /* Flawfinder: ignore */ { blob = file->readAll(); - } else { diff --git a/src/elogclublog.h b/src/elogclublog.h index defc01fb..380efddd 100644 --- a/src/elogclublog.h +++ b/src/elogclublog.h @@ -87,6 +87,5 @@ private slots: void showMessage(const QString &_t); void disableClubLogAction(const bool _b); void signalFileUploaded(QNetworkReply::NetworkError, QList<int>); - }; #endif // DOWNLOADCTY_H diff --git a/src/elogqrzlog.h b/src/elogqrzlog.h index 4bdb85c7..6cb583bb 100644 --- a/src/elogqrzlog.h +++ b/src/elogqrzlog.h @@ -117,6 +117,5 @@ private slots: OnlineMessageWidget *onlineMessage; //bool useQSOStationCallsign; - }; #endif // DOWNLOADCTY_H diff --git a/src/eqslutilities.h b/src/eqslutilities.h index 7a4a5de7..15840d18 100644 --- a/src/eqslutilities.h +++ b/src/eqslutilities.h @@ -87,6 +87,5 @@ private slots: void showMessage(const QString &_t); void disableeQSLAction(const bool _b); void signalFileUploaded(QNetworkReply::NetworkError, QList<int>); - }; #endif // EQSLUTILITIES_H diff --git a/src/fileawardmanager.h b/src/fileawardmanager.h index e29bb4f2..93fe30ff 100644 --- a/src/fileawardmanager.h +++ b/src/fileawardmanager.h @@ -49,7 +49,6 @@ public slots: DataProxy_SQLite *dataProxy; Utilities *util; World *world; - }; #endif // FILEAWARDMANAGER_H diff --git a/src/filemanager.h b/src/filemanager.h index 3a08bbf1..5060d27b 100644 --- a/src/filemanager.h +++ b/src/filemanager.h @@ -136,7 +136,6 @@ class FileManager : public QWidget bool rstTXDefault, rstRXDefault; // If true and a log is not including RST, 59 is automatically added - //bool printQs(const QString &_q, const QStringList _line); bool printQs(const QStringList &_line); //int confirmed; @@ -168,6 +167,5 @@ class FileManager : public QWidget signals: void addQSOToList(QStringList _qso); void queryError(QString _functionFailed, QString errorCodeS, QString nativeError, QString failedQuery); // To alert about any failed query execution - }; #endif // FILEMANAGER_H diff --git a/src/hamlibclass.h b/src/hamlibclass.h index 0a951274..80351f8f 100644 --- a/src/hamlibclass.h +++ b/src/hamlibclass.h @@ -142,9 +142,6 @@ public slots: bool readOnlyMode; // If true, KLog will not modify any parameter (freq/mode...) in the radio. KLog just will follow the radio. bool justEmitted; bool reading; // Just a semaphore to prevent several readings - //bool active; - - //QSerialPort *m_serial; }; #endif // HAMLIBCLASS_H diff --git a/src/infowidget.h b/src/infowidget.h index 71d2f43b..4f631ea6 100644 --- a/src/infowidget.h +++ b/src/infowidget.h @@ -82,7 +82,6 @@ class InfoWidget : public QWidget int currentLog; bool imperialSystem; QString dxLocator, localLocator; - }; #endif // INFOWIDGET_H diff --git a/src/klogdefinitions.h b/src/klogdefinitions.h index 21398104..ad898c62 100644 --- a/src/klogdefinitions.h +++ b/src/klogdefinitions.h @@ -64,11 +64,6 @@ struct Coordinate { #define QT_SKIP QString::SkipEmptyParts #define QT_ENDL endl #define QT_RETURNBYVALUE - #endif - - -//#if QT_VERSION>=0x041502 -//#else -//#endif +#endif #endif // KLOGDEFINITIONS_H diff --git a/src/locator.h b/src/locator.h index 38cd4cc2..68870a88 100644 --- a/src/locator.h +++ b/src/locator.h @@ -31,8 +31,6 @@ #include <QRegularExpression> #include "klogdefinitions.h" - - const double PI = 3.141592654; //http://en.wikipedia.org/wiki/Pi const bool LATITUDE = false; const bool LONGITUDE = true; @@ -75,8 +73,6 @@ class Locator{ //QChar theChar; //double my_lon, my_lat, other_lon, other_lat, beam, testNumb; //int ideg, imin, isec; - - }; #endif diff --git a/src/logmodel.h b/src/logmodel.h index 3d7156ec..9ae38b82 100644 --- a/src/logmodel.h +++ b/src/logmodel.h @@ -52,7 +52,6 @@ class LogModel : public QSqlRelationalTableModel signals: void queryError(QString functionFailed, QString errorCodeS, QString nativeError, QString failedQuery); // To alert about any failed query execution - }; #endif // LOGMODEL_H diff --git a/src/logwindow.h b/src/logwindow.h index e387ec2c..702a0d34 100644 --- a/src/logwindow.h +++ b/src/logwindow.h @@ -161,7 +161,6 @@ private slots: Utilities *util; QStringList columns; - //LogViewSortFilterProxyModel *proxyModel; //bool sortingThroughProxyModel; }; diff --git a/src/lotwutilities.cpp b/src/lotwutilities.cpp index 0350e260..7be1f3dc 100644 --- a/src/lotwutilities.cpp +++ b/src/lotwutilities.cpp @@ -318,7 +318,6 @@ int LoTWUtilities::download() startRequest(url); //qDebug() << "LoTWUtilities::download - END"; return 1; - } int LoTWUtilities::fullDownload() diff --git a/src/lotwutilities.h b/src/lotwutilities.h index 6b225621..6ce15de4 100644 --- a/src/lotwutilities.h +++ b/src/lotwutilities.h @@ -103,7 +103,6 @@ private slots: signals: void actionProcessLoTWDownloadedFile(QString _fn); - }; #endif // LOTWUTILITIES_H diff --git a/src/mainwindow.h b/src/mainwindow.h index cdd5f897..96ad6d4b 100644 --- a/src/mainwindow.h +++ b/src/mainwindow.h @@ -690,7 +690,6 @@ private slots: signals: void queryError(QString functionFailed, QString errorCodeS, QString nativeError, QString failedQuery); // To alert about any failed query execution - protected: void keyPressEvent(QKeyEvent *event) override; void closeEvent(QCloseEvent *event) override; diff --git a/src/searchmodel.h b/src/searchmodel.h index 85756a15..886da1d0 100644 --- a/src/searchmodel.h +++ b/src/searchmodel.h @@ -61,7 +61,6 @@ class SearchModel : public QSqlRelationalTableModel int dxcc, bandid, modeid, logn; signals: void queryError(QString functionFailed, QString errorCodeS, QString nativeError, QString failedQuery); // To alert about any failed query execution - }; #endif // SEARCHMODEL_H diff --git a/src/searchwidget.h b/src/searchwidget.h index 72959574..36f4d7c5 100644 --- a/src/searchwidget.h +++ b/src/searchwidget.h @@ -157,9 +157,6 @@ private slots: QAction *qslRecRequestedAct; QTimer *delayInputTimer; - - - }; #endif // SEARCHWIDGET_H diff --git a/src/searchwindow.h b/src/searchwindow.h index 00ad5695..5d919871 100644 --- a/src/searchwindow.h +++ b/src/searchwindow.h @@ -154,7 +154,6 @@ private slots: Utilities *util; bool showStationCallsignInHeader; - }; #endif // SEARCHWINDOW_H diff --git a/src/setuppages/setuppagecolors.h b/src/setuppages/setuppagecolors.h index 6e4f233b..edf269c5 100644 --- a/src/setuppages/setuppagecolors.h +++ b/src/setuppages/setuppagecolors.h @@ -93,7 +93,6 @@ private slots: 4 - Confirmed: Worked in this band. 5 - Confirmed: Confirmed in this band. */ - }; #endif // SETUPPAGECOLORS_H diff --git a/src/setuppages/setuppageelog.h b/src/setuppages/setuppageelog.h index 71bceb2a..c0813a31 100644 --- a/src/setuppages/setuppageelog.h +++ b/src/setuppages/setuppageelog.h @@ -74,6 +74,7 @@ private slots: protected: //void closeEvent(QCloseEvent *event); void showEvent(QShowEvent *event); + private: void setDefaults(); //QString defaultFileName; @@ -110,8 +111,6 @@ private slots: Utilities *util; QPalette palRed, palBlack; - - }; #endif // SETUPPAGEELOG_H diff --git a/src/setuppages/setuppagelogview.h b/src/setuppages/setuppagelogview.h index 81d497fc..6a306e1e 100644 --- a/src/setuppages/setuppagelogview.h +++ b/src/setuppages/setuppagelogview.h @@ -56,7 +56,6 @@ public slots: QListWidget *fieldsListWidget; DataProxy_SQLite *dataProxy; - }; #endif // SETUPPAGELOGVIEW_H diff --git a/src/setuppages/setuppagesats.cpp b/src/setuppages/setuppagesats.cpp index 4fd482f8..4ffc989f 100644 --- a/src/setuppages/setuppagesats.cpp +++ b/src/setuppages/setuppagesats.cpp @@ -90,14 +90,6 @@ SetupPageSats::SetupPageSats(DataProxy_SQLite *dp, QWidget *parent) : QWidget(pa setLayout(widgetLayout); - - - - //connect(newSatPushButton, SIGNAL(clicked ( )), this, SLOT(slotNewButtonClicked() ) ); - //QObject::connect(manager, SIGNAL(finished(QNetworkReply*)),this, SLOT(slotDownloadFinished(QNetworkReply*))); - //connect(setupD, SIGNAL(newSatRequested(true)), this, slotNewButtonClicked() ) - - createActions(); updateSelectedSats(); //qDebug() << "SetupPageSats::SetupPageSats - END"; @@ -345,6 +337,7 @@ void SetupPageSats::slotSatDoubleClicked(const QModelIndex & index) setSelectedSat((satsModel->index(row, 0)).data(0).toInt()); slotEditButtonClicked(); } + void SetupPageSats::slotAnalyzeNewSatData(const QStringList _qs) { Q_UNUSED(_qs); @@ -449,7 +442,6 @@ QStringList SetupPageSats::readSats() aux.clear(); _sats.clear(); - aux = "SELECT id, satarrlid, satname, uplink, downlink, satmode FROM satellites"; sqlOk = query.exec(aux); @@ -485,7 +477,6 @@ QStringList SetupPageSats::readSats() aux2.append((query.value(nameCol)).toString()); _sats.append(aux2); - } return _sats; } @@ -623,7 +614,6 @@ void SetupPageSats::slotExportButtonClicked() else { emit queryError(Q_FUNC_INFO, query.lastError().databaseText(), query.lastError().nativeErrorCode(), query.lastQuery()); - } QDateTime *dateTime = new QDateTime(); //dateTime->currentDateTime(); diff --git a/src/setuppages/setuppagesatsnew.cpp b/src/setuppages/setuppagesatsnew.cpp index ca8d1baa..e8b8b8e8 100644 --- a/src/setuppages/setuppagesatsnew.cpp +++ b/src/setuppages/setuppagesatsnew.cpp @@ -405,9 +405,7 @@ void SetupPageSatsNew::gatherAndSend() { //qDebug() << "SetupPageSatsNew::gatherAndSend: "; - // The previous lines will be removed once more contest types have been added - satData.clear(); satData << shortNameLineEdit->text() << nameLineEdit->text() << downlinkLineEdit->text() << uplinkLineEdit->text() << modesLineEdit->text(); @@ -427,10 +425,7 @@ void SetupPageSatsNew::gatherAndSend() } //qDebug() << "SetupPageSatsNew::gatherAndSend: EMITED"; - - emit newSatData(satData); - } void SetupPageSatsNew::slotCancelButtonClicked() diff --git a/src/setuppages/setuppagesubdivisions.cpp b/src/setuppages/setuppagesubdivisions.cpp index e9cea94a..ef6fc624 100644 --- a/src/setuppages/setuppagesubdivisions.cpp +++ b/src/setuppages/setuppagesubdivisions.cpp @@ -241,8 +241,6 @@ void SetupPageSubdivisions::createLogsModel() nameCol = rec.indexOf("dxcc"); logsModel->setHeaderData(nameCol, Qt::Horizontal, tr("DXCC")); - - logsModel->select(); } @@ -251,7 +249,6 @@ void SetupPageSubdivisions::slotLogSelected(const QModelIndex & index) //qDebug() << "SetupPageSubdivisions::slotLogSelected" ; int row = index.row(); setSelectedLog((logsModel->index(row, 0)).data(0).toInt()); - } void SetupPageSubdivisions::createActions() @@ -262,13 +259,11 @@ void SetupPageSubdivisions::createActions() connect(removePushButton, SIGNAL(clicked()), this, SLOT(slotRemoveButtonClicked() ) ); connect(logsView, SIGNAL(clicked(QModelIndex)), this, SLOT(slotLogSelected(QModelIndex) ) ); - } QStringList SetupPageSubdivisions::readLogs() { //qDebug() << "SetupPageSubdivisions::readLogs"; - QString aux, aux2; QStringList _logs; QSqlQuery query; @@ -279,7 +274,7 @@ QStringList SetupPageSubdivisions::readLogs() _logs.clear(); aux = "SELECT DISTINCT dxcc from primary_subdivisions"; - /int counter = 0; + //int counter = 0; sqlOk = query.exec(aux); if (sqlOk) { @@ -306,8 +301,6 @@ QStringList SetupPageSubdivisions::readLogs() } } - - void SetupPageSubdivisions::updateSelectedLogs() { //qDebug() << "SetupPageSubdivisions::updateSelectedLogs"; @@ -372,7 +365,6 @@ void SetupPageSubdivisions::setSelectedLog(const int _i) } } - void SetupPageSubdivisions::showError(const QString &_errorC) { QString text = QString(tr("An error has occurred showing the following error code:") + "\n'%1'").arg(_errorC); diff --git a/src/showerrordialog.h b/src/showerrordialog.h index 90ca440c..d1957715 100644 --- a/src/showerrordialog.h +++ b/src/showerrordialog.h @@ -46,7 +46,6 @@ private slots: QTextBrowser *textBrowser; QString text; QLabel *txtLabel; - }; diff --git a/src/softwareupdate.h b/src/softwareupdate.h index 945cb034..ddfcf9a9 100644 --- a/src/softwareupdate.h +++ b/src/softwareupdate.h @@ -87,7 +87,6 @@ private slots: //bool toUpdate; bool repositoryFound; // True when the versions have been checked to prevent multiple qmessagebox due to redirections bool messageShown; - }; #endif // SOFTWAREUPDATE_H diff --git a/src/softwareupdatedialog.h b/src/softwareupdatedialog.h index 74e784e3..240ff18e 100644 --- a/src/softwareupdatedialog.h +++ b/src/softwareupdatedialog.h @@ -45,7 +45,6 @@ private slots: QTextBrowser *textBrowser; QString text; QString _version; - }; #endif // SOFTWAREUPDATEDIALOG_H diff --git a/src/startwizard.cpp b/src/startwizard.cpp index 802a7161..4163a772 100644 --- a/src/startwizard.cpp +++ b/src/startwizard.cpp @@ -833,7 +833,6 @@ layout->addWidget(licenseBrowser); layout->addWidget(aceptLicCheckBox); setLayout(layout); - } int LicPage::nextId() const @@ -1023,7 +1022,6 @@ void CTYPage::slotDownloadError(const int ret) else */ if(errorCode == QNetworkReply::HostNotFoundError) - { i = QMessageBox::warning(this, tr("KLog"), tr("I can't find the host. Please check your network and try again\n" diff --git a/src/statisticswidget.h b/src/statisticswidget.h index 4532bfb5..083e164f 100644 --- a/src/statisticswidget.h +++ b/src/statisticswidget.h @@ -86,14 +86,10 @@ private slots: StatsDXCCOnSatsWidget *w14; StatsFieldPerBandWidget *w15; StatsFieldPerBandWidget *w16; + DataProxy_SQLite *dataProxy; - - - DataProxy_SQLite *dataProxy; - - - QComboBox *statisticToShowComboBox, *logComboBox; - QStringList statisticsToShowList; + QComboBox *statisticToShowComboBox, *logComboBox; + QStringList statisticsToShowList; }; diff --git a/src/tipsdialog.h b/src/tipsdialog.h index 17381d8c..89258834 100644 --- a/src/tipsdialog.h +++ b/src/tipsdialog.h @@ -73,8 +73,6 @@ private slots: DebugLogLevel logLevel; int tipId, tipMax; QString description; - - }; diff --git a/src/udpserver.h b/src/udpserver.h index 2a5e5270..d5acff90 100644 --- a/src/udpserver.h +++ b/src/udpserver.h @@ -117,8 +117,6 @@ class UDPServer : public QObject private slots: void slotReadPendingDatagrams(); - - }; #endif // UDPSERVER_H diff --git a/src/updatesettings.h b/src/updatesettings.h index c2ae539a..977e3212 100644 --- a/src/updatesettings.h +++ b/src/updatesettings.h @@ -48,7 +48,6 @@ class UpdateSettings : public QObject bool processConfigLine(const QString &_line); bool findInFile(); bool renameFile(const QString &_oldName, const QString &_newName); - }; #endif // UPDATESETTINGS_H diff --git a/src/widgets/adiflotwexportwidget.h b/src/widgets/adiflotwexportwidget.h index c1230ac5..53361f12 100644 --- a/src/widgets/adiflotwexportwidget.h +++ b/src/widgets/adiflotwexportwidget.h @@ -35,7 +35,6 @@ class AdifLoTWExportWidget : public QWidget { Q_OBJECT - public: explicit AdifLoTWExportWidget(DataProxy_SQLite *dp, const QString &_parentFunction, QWidget *parent = nullptr); ~AdifLoTWExportWidget(); @@ -94,7 +93,6 @@ private slots: QDate currentStart, currentEnd; bool starting; QList<int> qsos; - }; diff --git a/src/widgets/map/mapwidget.h b/src/widgets/map/mapwidget.h index 907a9939..faed23ce 100644 --- a/src/widgets/map/mapwidget.h +++ b/src/widgets/map/mapwidget.h @@ -66,7 +66,6 @@ private slots: int ColorRole = Qt::UserRole + 1002; Locator locator; //double lat, lon; - }; #endif // MAPWIDGET_H diff --git a/src/widgets/map/mapwindowwidget.h b/src/widgets/map/mapwindowwidget.h index 7f71c567..801af749 100644 --- a/src/widgets/map/mapwindowwidget.h +++ b/src/widgets/map/mapwindowwidget.h @@ -76,7 +76,6 @@ private slots: QColor workedColor; QColor confirmedColor; QColor defaultColor; - }; #endif // MAPWINDOWWIDGET_H diff --git a/src/widgets/onlinemessagewidget.cpp b/src/widgets/onlinemessagewidget.cpp index 023e1c46..a9d2a9fc 100644 --- a/src/widgets/onlinemessagewidget.cpp +++ b/src/widgets/onlinemessagewidget.cpp @@ -25,10 +25,7 @@ *****************************************************************************/ #include "onlinemessagewidget.h" -OnlineMessageWidget::OnlineMessageWidget(QWidget *parent) : QWidget(parent) -{ - -} +OnlineMessageWidget::OnlineMessageWidget(QWidget *parent) : QWidget(parent){} int OnlineMessageWidget::showMessage(QNetworkReply::NetworkError _error, OnLineProvider _prov, OnlineErrorCode _onlineError, OnlineErrorReason _onlineReason, const QString &_msg) @@ -95,8 +92,6 @@ int OnlineMessageWidget::showMessage(QNetworkReply::NetworkError _error, OnLineP msgBox.setStandardButtons(QMessageBox::Ok); msgBox.setDefaultButton(QMessageBox::Ok); return msgBox.exec(); - - } @@ -176,6 +171,5 @@ QString OnlineMessageWidget::translate(QNetworkReply::NetworkError _error) return QString(tr("Not identified")); break; } - return QString::number(_error); } diff --git a/src/widgets/onlinemessagewidget.h b/src/widgets/onlinemessagewidget.h index 9c91d606..89f507b4 100644 --- a/src/widgets/onlinemessagewidget.h +++ b/src/widgets/onlinemessagewidget.h @@ -44,7 +44,6 @@ public slots: private: QString translate(QNetworkReply::NetworkError _error); - }; #endif // ONLINEMESSAGEWIDGET_H diff --git a/src/widgets/showadifimportwidget.h b/src/widgets/showadifimportwidget.h index 471ed729..9b28d438 100644 --- a/src/widgets/showadifimportwidget.h +++ b/src/widgets/showadifimportwidget.h @@ -65,7 +65,6 @@ private slots: QTableWidget *tableWidget; QHeaderView *hv, *hh; - }; diff --git a/tests/tst_mainqsoentrywidget/tst_mainqsoentrywidget.cpp b/tests/tst_mainqsoentrywidget/tst_mainqsoentrywidget.cpp index c086cbc3..00403739 100644 --- a/tests/tst_mainqsoentrywidget/tst_mainqsoentrywidget.cpp +++ b/tests/tst_mainqsoentrywidget/tst_mainqsoentrywidget.cpp @@ -62,20 +62,11 @@ tst_MainQSOEntryWidget::tst_MainQSOEntryWidget() mainQSOEntryWidget = new MainQSOEntryWidget(dataProxy); } -tst_MainQSOEntryWidget::~tst_MainQSOEntryWidget() -{ +tst_MainQSOEntryWidget::~tst_MainQSOEntryWidget(){} -} +void tst_MainQSOEntryWidget::initTestCase(){} -void tst_MainQSOEntryWidget::initTestCase() -{ - -} - -void tst_MainQSOEntryWidget::cleanupTestCase() -{ - -} +void tst_MainQSOEntryWidget::cleanupTestCase(){} void tst_MainQSOEntryWidget::test_Constructor() { diff --git a/tests/tst_mainwindowsattab/tst_mainwindowsattab.cpp b/tests/tst_mainwindowsattab/tst_mainwindowsattab.cpp index d3213db1..b3a45b78 100644 --- a/tests/tst_mainwindowsattab/tst_mainwindowsattab.cpp +++ b/tests/tst_mainwindowsattab/tst_mainwindowsattab.cpp @@ -58,20 +58,11 @@ tst_MainQSOEntryWidget::tst_MainQSOEntryWidget() mainWindowSattab = new MainWindowSatTab(dataProxy); } -tst_MainQSOEntryWidget::~tst_MainQSOEntryWidget() -{ +tst_MainQSOEntryWidget::~tst_MainQSOEntryWidget(){} -} +void tst_MainQSOEntryWidget::initTestCase(){} -void tst_MainQSOEntryWidget::initTestCase() -{ - -} - -void tst_MainQSOEntryWidget::cleanupTestCase() -{ - -} +void tst_MainQSOEntryWidget::cleanupTestCase(){} void tst_MainQSOEntryWidget::test_Constructor() {