-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problems with deletion and Democles #52
Comments
In the same test class there is another problematic tests that only passes if assertions are switched off: Note: you might have to update Ibex first for the test to fail (I restructured the pattern network a bit). |
The test case |
Currently the following tests are ignored with errors during deletion:
|
Hi, could you please fix the deployable version of the IBeX engine (i.e., project builder)? I got the following error message:
EcoreUtils does not seem to exist in the deployable eMoflon Core module. Bests, |
Hi Greg, IBeX uses emoflon::core from the snapshot UpdateSite not stable. Please try to update core from: https://emoflon.org/emoflon-core-updatesite/snapshot/updatesite/ Cheers, |
Hi Tony, I was unable to install the emoflon::core from the snapshot on Eclipse Neon. I fixed the problematic version constraints. Could you please rebuild the update site? Many thanks and bests, |
Hi Greg, just deployed. Cheers, |
Hi Tony, I am somewhat frustrated because I cannot get the test workspace running (with the obvious consequence that I cannot fix these issues).
Are there any version restrictions for Xtext?
Bests, |
Hi Greg, it sounds as though:
I can't explain why the 2 GT projects aren't building, but if the other GT projects are ok, then it shouldn't be an XText problem. I hope it is also related to (1), i.e., perhaps some dependencies are missing from the workspace and still have to be imported (or you need to pull the latest changes). @patrickrobrecht can try to see if all tests run under Eclipse Neon. Please tell us if you're still stuck. Cheers, |
Hi Greg, hi Tony, I got IBeX working under Eclipse Neon. The only thing I had to do in addition to our README was to update Some little fixes in our testsuite (removing specific version numbers from dependency declarations) can be found here: eMoflon/emoflon-ibex-tests#84 |
Thanks, Patrick! I’ve merged your fix. |
Hi,
The first test case was always green after several runs. Does it still fail? Is it also a non-deterministic case? I checked the third case. When edges are deleted at the following phase (i.e., revoke nodes and edges in the source and target model): https://github.com/eMoflon/emoflon-ibex/blob/aad699ea5159b968ad0a8073e87cc2a9e42991ad/org.emoflon.ibex.tgg.core.runtime/src/org/emoflon/ibex/tgg/operational/defaults/IbexRedInterpreter.java#L36, non-containment edges are deleted in an arbitrary order, however, only the deletion of regular edges (all edges - containment edges - container edges (i.e., bidirectional edge whose opposite is a containment edge)) would be correct. (Container edges should be ignored completely.) Deletion of a container edge (e.g., This deletion order is now OK:
This deletion order fails in the current version:
I guess that this issue causes the non-deterministic bug in all the three cases. Bests, |
Hi Greg, thanks for your feedback. I was able to implement a bugfix (eMoflon/emoflon-ibex#358) which fixes the two test cases
by deleting container edges at the end just as containment edges. Update: Even with the bugfix |
Hi Greg,
to continue our work on deletion, I have marked a further problematic test
testsuite.ibex.ClassInhHier2DB_MA.sync.SyncForward.testDeleteIntermediateSuperClass_FWD()
with "FIXME Greg".You can simply remove the @ignore for this test and run it to reproduce the exception. I've been unable to understand why the deletion from our side should be in anyway wrong.
Cheers and thanks,
Tony
The text was updated successfully, but these errors were encountered: