Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Make Flag vs Country Code configurable #15

Open
MikeyGMT opened this issue Oct 30, 2016 · 2 comments
Open

Enhancement: Make Flag vs Country Code configurable #15

MikeyGMT opened this issue Oct 30, 2016 · 2 comments

Comments

@MikeyGMT
Copy link

Hi @CaMer0n
It would be useful to allow flags to be configurable as country and language codes are inconsistent - e.g. cy = Welsh vs CY = Cyprus.
Full analysis is described over here e107inc/e107#1971.
Thanks
Mike

@CaMer0n
Copy link
Member

CaMer0n commented Oct 31, 2016

All the flag icons are configurable by modifying the css in one's style.css file. I will fix the Welsh one. Are there other flags missing or incorrect?

@MikeyGMT
Copy link
Author

MikeyGMT commented Nov 5, 2016

Thanks @CaMer0n I'll do some checks - there are a number of well known conflicts.
For example;
en - English - UK Flag vs USA flag.
pt - Portuguese - Portugal vs Brasil flag.
fr - French - French vs Canadian flag.
Spanish, Chinese, German etc are languages used by different countries.
Each could be applicable only to the market a site is targeted at, but be irritating if the incorrect flag is displayed for a market, hence if it were configurable, then the site admin could choose without hacking code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants