Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning sign in Feature Comparison table #18

Closed
roosephu opened this issue Mar 2, 2021 · 1 comment
Closed

Warning sign in Feature Comparison table #18

roosephu opened this issue Mar 2, 2021 · 1 comment

Comments

@roosephu
Copy link

roosephu commented Mar 2, 2021

In the Feature Comparison table, there is a warning sign for DoubleFloats on dynamic memory allocation. Could you please elaborate a little bit? Are you referring to the conversion from a Double64 to a (Float64, Float64) pair? Does this explain why MultiFloats is faster than DoubleFloats (assuming both use the same number of operations)?

BTW, thanks for making such a performant library with precise code!

@dzhang314
Copy link
Owner

Hey @roosephu, thanks for your interest in MultiFloats.jl! I actually removed that warning sign a while ago, but I wanted to write a brief note on its history to close this thread. At one point in the past, I observed some instances where DoubleFloats.jl would allocate in situations where it didn't need to, so I added the warning sign. However, I lost the old version of the benchmark script where I observed this, and I haven't been able to recreate it since. Either this was fixed at some point in DoubleFloats.jl, or my recollection may simply have been mistaken.

In either case, I can no longer substantiate the claim that DoubleFloats.jl makes unnecessary allocations, so I have changed its grade to a check mark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants