Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product host url option is hardcoded #2

Open
fsainz opened this issue Nov 7, 2014 · 1 comment
Open

Product host url option is hardcoded #2

fsainz opened this issue Nov 7, 2014 · 1 comment

Comments

@fsainz
Copy link
Contributor

fsainz commented Nov 7, 2014

https://github.com/ZEITIO/questionizer/blob/master/config/initializers/smtp_and_url_options.rb#L4

What is the approach here? we could do yet another .example.rb, we could add it to secrets.yml, we could create another configuration file for non secret options...

@ariera
Copy link

ariera commented Nov 7, 2014

I don’t see a problem leaving it there. Is it being used somewhere else? Or is the domain of the app in production going to change somehow often?

I once saw a guy using I18n for config options. It is kind of convenient (but also very misleading) you just add a config.yml file in your locales dir and the you can do I18n.t(‘production.host’) 💃 XDD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants