Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AttributeError: module 'hydrogym.firedrake' has no attribute 'IPCS' #193

Open
dmitryshribak opened this issue Sep 17, 2024 · 2 comments
Open

Comments

@dmitryshribak
Copy link

What solver should I use, since latest code does not include IPCS yet all the examples do?

Traceback (most recent call last):
File "/IdeaProjects/hydrogym/examples/ppo/cyl.py", line 53, in
ppo.ppo(
File "/IdeaProjects/hydrogym/examples/ppo/ppo.py", line 361, in ppo
env = env_fn()
File "/IdeaProjects/hydrogym/examples/ppo/cyl.py", line 54, in
lambda: gym.make("Cylinder-v0", env_config=env_config),
File "/home/firedrake/firedrake/lib/python3.10/site-packages/gym/envs/registration.py", line 640, in make
env = env_creator(**_kwargs)
File "/IdeaProjects/hydrogym/examples/ppo/cyl.py", line 17, in init
"solver": hydrogym.firedrake.IPCS,
AttributeError: module 'hydrogym.firedrake' has no attribute 'IPCS'

@ReHoss
Copy link

ReHoss commented Oct 27, 2024

@dmitryshribak The examples are, unfortunately, outdated. You should use the semi-implicit solver from https://github.com/dynamicslab/hydrogym/blob/main/hydrogym/firedrake/solvers/bdf_ext.py

@ludgerpaehler
Copy link
Collaborator

We are currently fixing issues with the main core HydroGym code + its flow environments, and will then rewrite the examples (+notebooks).

I'm afraid it'll probably take +/- 1 month though..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants