Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for "Platforms:" in LID file #3

Open
cgay opened this issue Jan 17, 2024 · 3 comments
Open

Improve support for "Platforms:" in LID file #3

cgay opened this issue Jan 17, 2024 · 3 comments

Comments

@cgay
Copy link
Member

cgay commented Jan 17, 2024

This would avoid having to list all the platforms and would allow us to write the registry entry in the registry/generic/. It's also nice for self-documenting purposes compared to "here's a list of platforms; you decide if it's complete".

@cgay cgay changed the title Support "Platforms: all" in LID file Improve support for "Platforms:" in LID file Mar 13, 2024
@cgay
Copy link
Member Author

cgay commented Mar 13, 2024

We could also use a way to indicate that a LID doesn't support a specific platform. For example we have a lot of libraries that only support x86-win32 and rather than listing all the other platforms in the non-x86-win32 LID file we could use one of these:

Platforms: -x86-win32

Antiplatforms: x86-win32

Platforms: not x86-win32

The specific syntax probably doesn't matter too much.

cgay referenced this issue in cgay/opendylan Mar 13, 2024
These LID files are included in other platform-specific LID files (usually
win32 LID files) and hence dylan-tool decides they aren't applicable to Unix
platforms unless those platforms are specifically listed. See
https://github.com/dylan-lang/dylan-tool/issues/78
cgay referenced this issue in cgay/opendylan Mar 24, 2024
These LID files are included in other platform-specific LID files (usually
win32 LID files) and hence dylan-tool decides they aren't applicable to Unix
platforms unless those platforms are specifically listed. See
https://github.com/dylan-lang/dylan-tool/issues/78
cgay referenced this issue in cgay/opendylan Apr 8, 2024
These LID files are included in other platform-specific LID files (usually
win32 LID files) and hence dylan-tool decides they aren't applicable to Unix
platforms unless those platforms are specifically listed. See
https://github.com/dylan-lang/dylan-tool/issues/78
@cgay cgay transferred this issue from dylan-lang/dylan-tool Apr 21, 2024
@cgay
Copy link
Member Author

cgay commented Jun 14, 2024

I would like to add support for these special platforms keywords:

  • all -- like it says on the tin. This allows writing the registry entry in registry/generic
  • macos -- currently would be equivalent to x86_64-darwin
  • windows -- currently would be equivalent to win32
  • unix -- currently would be equivalent to x86_64-darwin + x86_64-linux + x86_64-freebsd + x86_64-netbsd + all the 32-bit versions of those unixen.

When this is done, or even partly done, update the documentation here: https://opendylan.org/library-reference/lid.html#standard-lid-keywords

@cgay
Copy link
Member Author

cgay commented Jun 14, 2024

Also, would it make sense to write a registry file for each covered platform if the spec is not Platforms: all? That is, if it's Platforms: unix, write a registry file to registry/x86_64-linux, registry/x86_64-darwin, etc.

Currently deft only writes a registry file for the current platform, in the platform-specific registry directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant