Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow redirects.json to work with or without trailing slash #1143

Open
yndajas opened this issue Apr 13, 2023 · 0 comments
Open

Allow redirects.json to work with or without trailing slash #1143

yndajas opened this issue Apr 13, 2023 · 0 comments

Comments

@yndajas
Copy link
Member

yndajas commented Apr 13, 2023

When debugging an issue with a couple of redirects on #1101, I found that they weren't working because I'd not put trailing slashes in the to property of the object in redirects.json. Ideally redirects.js would look for a match for window.location with or without the trailing slash (this should be an easy fix)

We could just document the requirement for redirects.json to match window.location exactly, trailing slash or not, but it would be better not to have to worry about whether the slash exists in a given context

@yndajas yndajas changed the title Allow redirects.json to work with or without trailing slash Allow redirects.json to work with or without trailing slash Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant