Setting a song as ringtone crashes the app

[kodeblacc]

Expected behavior

I expected to be able to set a track as ringtone

Actual behavior

When I select a track to set as ringtone, the app crashes

How to reproduce

• download the app from fdroid
• launch the app and allow all permissions from your app settings
• click on the 3 dots beside any track to access it's options
• select option to set track as ringtone and the app crashes

• Browser: Infinix note 4
• Operating system: android 7.0
• App version: v1.0

Recording Of The Bug

https://youtu.be/tu0mZtv-lqM

---

Posted on Utopian.io - Rewarding Open Source Contributors

---

[dwi336]

Hi,

Thank you for the report.

WRITE_SETTINGS permission must be explicitly granted for the app since M. I will fix it in the next release.

Thank you.

dwi336

[kodeblacc]

You are welcome. You're doing a nice job

…

On Sun, Mar 11, 2018, 21:46 dwi336 ***@***.***> wrote: Hi, Thank you for the report. WRITE_SETTINGS permission must be explicitly granted for the app since M. I will fix it in the next release. Thank you. dwi336 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#5 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AhrOEqkeF_oUWtOr_l5lGZYCkT4PH6Zjks5tdY0JgaJpZM4SlX1Y> .

[dwi336]

Changed

Eleven/src/main/java/org/lineageos/eleven/utils/MusicUtils.java

Line 1203 in a1dd9d8

// Check since M whether has the write settings permission or not.

// Check since M whether has the write settings permission or not.
boolean settingsCanWrite = true;
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M){
settingsCanWrite = Settings.System.canWrite(context);
if (!settingsCanWrite) {
// If do not have write settings permission then open the Can modify system settings panel.
Intent intent = new Intent(Settings.ACTION_MANAGE_WRITE_SETTINGS);
context.startActivity(intent);
}
}
if ( settingsCanWrite ) {
Settings.System.putString(resolver, Settings.System.RINGTONE, uri.toString());
final String message = context.getString(R.string.set_as_ringtone,
cursor.getString(2));
Toast.makeText((Activity)context, message, Toast.LENGTH_SHORT).show();
}

In my tests it works.

dwi336

[kodeblacc]

Well the function didn't work on my phone android 7.0 and I just recently upgraded to Oreo still same issue

…

On Sun, Mar 11, 2018, 22:38 dwi336 ***@***.***> wrote: Changed https://github.com/dwi336/Eleven/blob/a1dd9d8d27079828840b830d8f3e133f8e8f227a/src/main/java/org/lineageos/eleven/utils/MusicUtils.java#L1203 // Check since M whether has the write settings permission or not. boolean settingsCanWrite = true; if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M){ settingsCanWrite = Settings.System.canWrite(context); if (!settingsCanWrite) { // If do not have write settings permission then open the Can modify system settings panel. Intent intent = new Intent(Settings.ACTION_MANAGE_WRITE_SETTINGS); context.startActivity(intent); } } if ( settingsCanWrite ) { Settings.System.putString(resolver, Settings.System.RINGTONE, uri.toString()); final String message = context.getString(R.string.set_as_ringtone, cursor.getString(2)); Toast.makeText((Activity)context, message, Toast.LENGTH_SHORT).show(); } In my tests it works. dwi336 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#5 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AhrOEn9ZqRvcLP3OjSSf7ftdsDV8XI2Nks5tdZlygaJpZM4SlX1Y> .

[kodeblacc]

Okay.

…

On Wed, Mar 14, 2018, 23:10 dwi336 ***@***.***> wrote: Reopened #5 <#5>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#5 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AhrOEjLe9OOeG66hT1lAVDU1YYAk7Plfks5teZVcgaJpZM4SlX1Y> .

[dwi336]

On physical devices I only use custom ROMs. So I tested the function with Android emulator. Nougat for example:

Could you please post screenshots or logcat?

Thank you

dwi336

[kodeblacc]

I'm not a person per say. I just reported the issue so you could work a fix. Screenshots of what do you need

…

On Wed, Mar 14, 2018, 23:44 dwi336 ***@***.***> wrote: On physical devices I only use custom ROMs. So I tested the function with Android emulator. Nougat for example: [image: screenshot_1521067095] <https://user-images.githubusercontent.com/30302193/37434875-6e130e50-27e1-11e8-8312-22da6d495d31.png> [image: screenshot_1521067095] <https://user-images.githubusercontent.com/30302193/37434896-7d14a88c-27e1-11e8-9328-a24c6c833b80.png> Could you please post screenshots or logcat? Thank you dwi336 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#5 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AhrOEgOE59CixYeVHXIYzkCBi_SRZ-1xks5teZ07gaJpZM4SlX1Y> .

[dwi336]

1. What happened, if you click on the pop up menu entry? Did the app call up and switch to the system settings menu (activity)?
2. In the system settings menu, did you allow the app to modify the system settings?

[kodeblacc]

Yes I did that. I always allow permissions for all my apps I recently upgraded to Android 8.0 And I'm still experiencing the bug

…

On Thu, Mar 15, 2018, 00:07 dwi336 ***@***.***> wrote: 1. What happened, if you click on the pop up menu entry? Did the app call up and switch to the system settings menu (activity)? 2. In the system settings menu, did you allow the app to modify the system settings? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#5 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AhrOEjU1iYIhzhusGi9uFxjGdTV-xYTBks5teaLIgaJpZM4SlX1Y> .

[kodeblacc]

Hello, I'm writing this mail irrespective of my bug reports. Recently I've been doing promotion for several open source projects. I'm a huge fan of your app especially because it's the default music player on my lineage 9s custom rom. I'll love to do a visibility campaign of your project so that people who don't have utilize custom roms where your app is present to know about it.

…

On Thu, Mar 15, 2018, 00:11 Otunji Favour ***@***.***> wrote: Yes I did that. I always allow permissions for all my apps I recently upgraded to Android 8.0 And I'm still experiencing the bug On Thu, Mar 15, 2018, 00:07 dwi336 ***@***.***> wrote: > > 1. What happened, if you click on the pop up menu entry? Did the app > call up and switch to the system settings menu (activity)? > 2. In the system settings menu, did you allow the app to modify the > system settings? > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#5 (comment)>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AhrOEjU1iYIhzhusGi9uFxjGdTV-xYTBks5teaLIgaJpZM4SlX1Y> > . >

[dwi336]

Hello,

Thank for your praise, but I just building the upstream app from

https://github.com/LineageOS/android_packages_apps_Eleven

Nevertheless I am happy that someone else like the app. I will try to find more devices to adjust the bug on different stock roms. I am very sorry, but unfortunately this will take some time.

dwi336

[kodeblacc]

No qualms

…

On Fri, Mar 16, 2018, 21:58 dwi336 ***@***.***> wrote: Hello, Thank for your praise, but I just building the upstream app from https://github.com/LineageOS/android_packages_apps_Eleven Nevertheless I am happy that someone else like the app. I will try to find more devices to adjust the bug on different stock roms. I am very sorry, but unfortunately this will take some time. dwi336 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#5 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AhrOEmc-JDnbdRhVVUNd9phvWVM476QVks5tfCdugaJpZM4SlX1Y> .