Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harp throws an error with single-end reads #2

Open
dmalzl opened this issue Nov 7, 2019 · 1 comment
Open

harp throws an error with single-end reads #2

dmalzl opened this issue Nov 7, 2019 · 1 comment

Comments

@dmalzl
Copy link

dmalzl commented Nov 7, 2019

I course of resolving #1 I simply copied the code for the function into my script and loaded conifur, gyro, converge and travis manually in addition. However, when using single-end files the function throws an error resulting from the undefined variable paired when calling bowtie2 in line 88. This is due to the fact that if fastqFiles2 is not given (hence NULL) the preceeding if statement is not called and paired is not set. Putting

  if(!sam){
    if(!is.null(fastqFiles2)){
      paired=TRUE
    } else{
      paired=FALSE
    }
    sam1 <- bowtie2(fastqFiles1, index1prefix, if(paired){fastqFiles2}, discordant=TRUE, appendIndexToName=TRUE, reorder=TRUE, threads=threads )
    sam2 <- bowtie2(fastqFiles1, index2prefix, if(paired){fastqFiles2}, discordant=TRUE, appendIndexToName=TRUE, reorder=TRUE, threads=threads )
  }

reolves the problem

@dvera
Copy link
Owner

dvera commented Feb 18, 2020

Sorry for the delay, I didn't get notified of the issue. Should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants