Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing envvar escape #689

Closed
wants to merge 1 commit into from
Closed

Conversation

dario-nuro
Copy link

Allows new install after cloning.

@maxhelias
Copy link
Collaborator

Using ${SERVER_NAME} substitutes the value immediately in Docker Compose, while $${SERVER_NAME} delays substitution until runtime inside the container. In your case, the final value by default will be : https://localhost, php:80/.well-known/mercure and it's not a good value.

@maxhelias maxhelias closed this Nov 12, 2024
@dario-nuro
Copy link
Author

Thanks for checking and sorry for rushing into an improper solution, but it allowed me to install.

@dario-nuro dario-nuro deleted the dario241111 branch November 13, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants