설정 화면에 versionCode 나오는 방식 변경 & MVP 제거 #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ${versionName} -> ${versionName}.${versionCode}
|
다들 확인하셨다 생각하고 merge 하겠습니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
history slack: https://duckie-team.slack.com/archives/C054HU0DHGA/p1682857473302919
관련 유관자 분들은 전부 reviewer 으로 두었습니다.
작업 내용
설정 화면에 versionCode 나오는 방식을 변경했습니다.
${versionName}->${versionName}.${versionCode}MVP 도 제거하기로 이야기가 된 것 같아, 해당 내용도 여기에서 반영했습니다. (cc @EvergreenTree97)
생각해보니 크게 작업할 게 없는 내용이어서 이렇게 작업했습니다.
이제 이런 식으로 나옵니다.
기타 앞광고
QA 하기 쉬운 방법에 대해서도 요즘 고민해보고 있습니다.
ex. 배포용 flavor 를 만들어서 versionName 및 versionCode 를 floating 으로 띄워주기 등
아이디어 있으면 #386 에 바로 올려주세요~ (@goddoro, @EvergreenTree97, @limsaehyun)