온보딩 도중 종료 시, 카카오 로그인부터 다시 시작해야 하는 문제 수정 #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riflockle7
reviewed
Sep 23, 2023
Comment on lines
-53
to
-55
| // 3. DataStore 에 id 값이 있는지 체크 | ||
| val meId = getMeId() ?: duckieClientLogicProblemException(code = ClientMeIdNull) | ||
|
|
There was a problem hiding this comment.
flow 가 수정되면서, 이번 기회에 번호도 일괄 수정되면 좋겠네요
(정작 저도 피처 플래그 갱신 추가할 때, 번호 수정을 제대로 못해놓긴 했지만 😂 )
There was a problem hiding this comment.
번호 주석 덕분에 로직이 쉽게 이해됐던것 같아요 ㅋㅋㅋ 너무 좋았씁니다
주석 최신화 해놓을게요~
riflockle7
reviewed
Sep 23, 2023
Comment on lines
-53
to
-54
| // 3. DataStore 에 id 값이 있는지 체크 | ||
| val meId = getMeId() ?: duckieClientLogicProblemException(code = ClientMeIdNull) |
There was a problem hiding this comment.
이게 당장 봤을때는 말이 안되어 보였을텐데요
온보딩 과정 끝마친 이후에 setMeId 를 하고 있을거예요
그래서 온보딩 도중 종료하면, 카카오 로그인부터 순차적으로 해야했을테고..! 잘 수정하신 거 같습니다
온보딩 도중 종료하고나서, 동작이 어떻게 되는지만 확인하면 될 것 같습니다!
There was a problem hiding this comment.
스크린샷에 올린 영상이 온보딩 도중 종료하고, 다시 들어왔을 때의 경우인데 한번 봐주실 수 있을까여?
There was a problem hiding this comment.
스크린샷에 올린 영상이 온보딩 도중 종료하고, 다시 들어왔을 때의 경우인데 한번 봐주실 수 있을까여?
아아 봤어요 ㅋㅋ 👌
riflockle7
approved these changes
Sep 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
MeRepository로직을 바꾸었는데, 사이드 이펙 발생하는지 확인 부탁드립니다! @riflockle7 5be837detc
Screenshot
default.webm