Skip to content

Commit

Permalink
Fix autofill copy keys and squash warnings (#3358)
Browse files Browse the repository at this point in the history
Task/Issue URL:
https://app.asana.com/0/1201037661562251/1208424278203049/f

**Description**:

There were several localization warnings introduced during [✓ macOS -
Mitigate users concerns about Password Manager
security](https://app.asana.com/0/1199230911884351/1207411921782782/f)

- UserText.pmSaveCredentialsSecurityInfo and
UserText.pmSaveCredentialsSecurityInfoAutolockOff have same keys which
can‘t be localized and causes warning
- UserText.pmEmptyStateDefaultDescription has same key with
pmEmptyStateDefaultDescriptionAutolockOff

Also there were some warnings about stale strings that are no longer in
use so I removed them in the second commit.

**Steps to test this PR**:
Change to any language other than English and check:
1. The password manager empty state string (with autolock on and off).
Check links work and end up in the right place.
2. The tooltip text on the save password dialog (with autolock on and
off). Check links work and end up in the right place.

<!--
Tagging instructions
If this PR isn't ready to be merged for whatever reason it should be
marked with the `DO NOT MERGE` label (particularly if it's a draft)
If it's pending Product Review/PFR, please add the `Pending Product
Review` label.

If at any point it isn't actively being worked on/ready for
review/otherwise moving forward (besides the above PR/PFR exception)
strongly consider closing it (or not opening it in the first place). If
you decide not to close it, make sure it's labelled to make it clear the
PRs state and comment with more information.
-->

**Definition of Done**:

* [ ] Does this PR satisfy our [Definition of
Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)?

---
###### Internal references:
[Pull Request Review
Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f)
[Software Engineering
Expectations](https://app.asana.com/0/59792373528535/199064865822552)
[Technical Design
Template](https://app.asana.com/0/59792373528535/184709971311943)
[Pull Request
Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)
  • Loading branch information
graeme authored Oct 4, 2024
1 parent 21b61be commit a599ccb
Show file tree
Hide file tree
Showing 2 changed files with 96 additions and 216 deletions.
Loading

0 comments on commit a599ccb

Please sign in to comment.