Malicious site protection address bar and privacy dashboard changes #3718
+209
−23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1206329551987282/1208959082985728/f
Tech Design: https://app.asana.com/0/1206329551987282/1207273224076495/f
CC: @not-a-rootkit
Description:
This PR addresses the following:
Steps to test this PR:
Scenario 1 - Special Error Pages show globe icon in the address bar
Ensure that the below URLs show the globe icon in the Address Bar as per Figma Design
Scenario 2 - Malicious Sites show alert icon in the address bar
a. http://privacy-test-pages.site/security/badware/phishing.html
b. http://privacy-test-pages.site/security/badware/malware.html
Scenario 3 - Malicious Sites show updated privacy dashboard
a. http://privacy-test-pages.site/security/badware/phishing.html
b. http://privacy-test-pages.site/security/badware/malware.html
Scenario 4 - Accepting visiting SSL Insecure website (Bonus Point)
Definition of Done (Internal Only):
Copy Testing:
’
rather than'
Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template