Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Missing Enum to Freemium RMF Implementation #1114

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

aataraxiaa
Copy link
Contributor

@aataraxiaa aataraxiaa commented Dec 4, 2024

Required:

Task/Issue URL: https://app.asana.com/0/1206488453854252/1208904081551825/f
iOS PR: duckduckgo/iOS#3673
macOS PR: duckduckgo/macos-browser#3631
What kind of version bump will this require?: Patch

Description: Adding missing Freemium RMF enum

Steps to test this PR:

  1. Green CI is fine here

Internal references:

Software Engineering Expectations
Technical Design Template

@aataraxiaa aataraxiaa self-assigned this Dec 4, 2024
@aataraxiaa aataraxiaa marked this pull request as ready for review December 4, 2024 17:59
@aataraxiaa aataraxiaa requested a review from samsymons December 4, 2024 17:59
Copy link
Contributor

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aataraxiaa aataraxiaa merged commit f0755fb into main Dec 5, 2024
12 of 13 checks passed
@aataraxiaa aataraxiaa deleted the pete/complete-freemium-RMF-implementation branch December 5, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants