Remove an unnecessary step when stopping the tunnel #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 28, 2024
diegoreymendez
commented
Nov 28, 2024
| @@ -895,10 +896,6 @@ open class PacketTunnelProvider: NEPacketTunnelProvider { | |||
| private func stopAdapter() async throws { | |||
| try await withCheckedThrowingContinuation { (continuation: CheckedContinuation<Void, Error>) in | |||
| adapter.stop { [weak self] error in | |||
| if let self { | |||
| self.handleAdapterStopped() | |||
There was a problem hiding this comment.
This was causing some trouble in the stop pixels not firing, likely because this was causing a delay and the tunnel was killed.
This isn't necessary as it's already done in line 889 anyway.
diegoreymendez
changed the title
samsymons
approved these changes
Nov 28, 2024
diegoreymendez
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Nov 28, 2024
Task/Issue URL: https://app.asana.com/0/1207603085593419/1208865941226621/f BSK PR: duckduckgo/BrowserServicesKit#1102 iOS PR: duckduckgo/iOS#3639 ## Description Changes how the tunnel is restarted on app update so that it won't fail to start again..
diegoreymendez
added a commit
to duckduckgo/iOS
that referenced
this pull request
Nov 28, 2024
Task/Issue URL: https://app.asana.com/0/1207603085593419/1208865941226621/f BSK PR: duckduckgo/BrowserServicesKit#1102 macOS PR: duckduckgo/macos-browser#3608 ## Description Removes a duplicated step from the tunnel stop logic that was causing some trouble in the logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1207603085593419/1208865941226621/f
iOS PR: duckduckgo/iOS#3639
macOS PR: duckduckgo/macos-browser#3608
What kind of version bump will this require?: Patch
Description
Removes a duplicated step from the tunnel stop logic that was causing some trouble in the logs.
Testing
Use the macOS PR to test.
Internal references:
Software Engineering Expectations
Technical Design Template