Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update C-S-S to 6.29.0 #1062

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Update C-S-S to 6.29.0 #1062

merged 1 commit into from
Nov 5, 2024

Conversation

ayoy
Copy link
Contributor

@ayoy ayoy commented Nov 5, 2024 •
edited
Loading

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/1201048563534612/1208699974934565/f
iOS PR: duckduckgo/iOS#3541
macOS PR: duckduckgo/macos-browser#3515
What kind of version bump will this require?: Minor

Description:
This C-S-S version only adds new functionality to help build macOS New Tab Page.

Steps to test this PR:
Verify that CI is green.

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16
  • macOS 10.15
  • macOS 11
  • macOS 12
Internal references:

Software Engineering Expectations
Technical Design Template

@ayoy ayoy self-assigned this Nov 5, 2024
@ayoy ayoy marked this pull request as ready for review November 5, 2024 15:45
@ayoy ayoy requested a review from aataraxiaa November 5, 2024 15:49
aataraxiaa
aataraxiaa approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@aataraxiaa aataraxiaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @ayoy! CI is ✅

@ayoy ayoy merged commit 64a5d8d into main Nov 5, 2024
13 checks passed
@ayoy ayoy deleted the dominik/css-update branch November 5, 2024 16:11
samsymons added a commit that referenced this pull request Nov 5, 2024
@samsymons
Merge branch 'main' into dominik/xcode-16
9a8a9e0 
* main:
  Update C-S-S to 6.29.0 (#1062)
  Send pixel on sync secure storage read failure (#1058)
samsymons added a commit that referenced this pull request Nov 6, 2024
@samsymons
Merge branch 'main' into sam/migrate-daily-and-count-type-to-legacy-s…
80e4fcf 
…tatus

* main:
  Update C-S-S to 6.29.0 (#1062)
  Send pixel on sync secure storage read failure (#1058)
samsymons added a commit that referenced this pull request Nov 6, 2024
@samsymons
Merge branch 'main' into sam/vpn-clean-up
fdd840c 
* main:
  Deprecate PixelKit daily pixel suffixes (#1060)
  Update C-S-S to 6.29.0 (#1062)
  Send pixel on sync secure storage read failure (#1058)
samsymons added a commit that referenced this pull request Nov 6, 2024
@samsymons
Merge branch 'main' into sam/remove-test-rollout-pixel
527617c 
* main:
  VPN clean-up (#1041)
  Deprecate PixelKit daily pixel suffixes (#1060)
  Update C-S-S to 6.29.0 (#1062)
  Send pixel on sync secure storage read failure (#1058)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aataraxiaa aataraxiaa aataraxiaa approved these changes

Assignees

@ayoy ayoy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayoy @aataraxiaa