-
Notifications
You must be signed in to change notification settings - Fork 35
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge remote-tracking branch 'origin/main' into graeme/fix-geoswitchi…
…ng-bug
- Loading branch information
Showing
11 changed files
with
241 additions
and
182 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
104 changes: 104 additions & 0 deletions
104
Sources/Bookmarks/Migrations/BookmarkFormFactorFavoritesMigration.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,104 @@ | ||
| // | ||
| // Copyright © 2023 DuckDuckGo. All rights reserved. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| // | ||
|
|
||
| import Foundation | ||
| import CoreData | ||
| import Persistence | ||
| import Common | ||
|
|
||
| public class BookmarkFormFactorFavoritesMigration { | ||
|
|
||
| public enum MigrationErrors { | ||
| case couldNotLoadDatabase | ||
| } | ||
|
|
||
| public static func getFavoritesOrderFromPreV4Model(dbContainerLocation: URL, | ||
| dbFileURL: URL, | ||
| errorEvents: EventMapping<MigrationErrors>? = nil) -> [String]? { | ||
| var oldFavoritesOrder: [String]? | ||
|
|
||
| let metadata = try? NSPersistentStoreCoordinator.metadataForPersistentStore(ofType: NSSQLiteStoreType, | ||
| at: dbFileURL) | ||
| if let metadata, let version = metadata["NSStoreModelVersionHashesVersion"] as? Int, version < 4 { | ||
| // Before migrating to latest scheme version, read order of favorites from DB | ||
|
|
||
| let v3BookmarksModel = NSManagedObjectModel.mergedModel(from: [Bookmarks.bundle], forStoreMetadata: metadata)! | ||
|
|
||
| let oldDB = CoreDataDatabase(name: "Bookmarks", | ||
| containerLocation: dbContainerLocation, | ||
| model: v3BookmarksModel) | ||
| oldDB.loadStore { context, error in | ||
| guard let context = context else { | ||
| errorEvents?.fire(.couldNotLoadDatabase, error: error) | ||
| return | ||
| } | ||
|
|
||
| let favs = BookmarkUtils.fetchLegacyFavoritesFolder(context) | ||
| oldFavoritesOrder = favs?.favoritesArray.compactMap { $0.uuid } | ||
| } | ||
| } | ||
| return oldFavoritesOrder | ||
| } | ||
|
|
||
| public static func migrateToFormFactorSpecificFavorites(byCopyingExistingTo folderID: FavoritesFolderID, | ||
| preservingOrderOf orderedUUIDs: [String]?, | ||
| in context: NSManagedObjectContext) { | ||
| assert(folderID != .unified, "You must specify either desktop or mobile folder") | ||
|
|
||
| guard let favoritesFolder = BookmarkUtils.fetchFavoritesFolder(withUUID: FavoritesFolderID.unified.rawValue, in: context) else { | ||
| return | ||
| } | ||
|
|
||
| if let orderedUUIDs { | ||
| // Fix order of favorites | ||
| let favorites = favoritesFolder.favoritesArray | ||
|
|
||
| for fav in favorites { | ||
| fav.removeFromFavorites(favoritesRoot: favoritesFolder) | ||
| } | ||
|
|
||
| for uuid in orderedUUIDs { | ||
| if let fav = favorites.first(where: { $0.uuid == uuid}) { | ||
| fav.addToFavorites(favoritesRoot: favoritesFolder) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| if BookmarkUtils.fetchFavoritesFolder(withUUID: FavoritesFolderID.desktop.rawValue, in: context) == nil { | ||
| let desktopFavoritesFolder = BookmarkUtils.insertRootFolder(uuid: FavoritesFolderID.desktop.rawValue, into: context) | ||
|
|
||
| if folderID == .desktop { | ||
| favoritesFolder.favoritesArray.forEach { bookmark in | ||
| bookmark.addToFavorites(favoritesRoot: desktopFavoritesFolder) | ||
| } | ||
| } else { | ||
| desktopFavoritesFolder.shouldManageModifiedAt = false | ||
| } | ||
| } | ||
|
|
||
| if BookmarkUtils.fetchFavoritesFolder(withUUID: FavoritesFolderID.mobile.rawValue, in: context) == nil { | ||
| let mobileFavoritesFolder = BookmarkUtils.insertRootFolder(uuid: FavoritesFolderID.mobile.rawValue, into: context) | ||
|
|
||
| if folderID == .mobile { | ||
| favoritesFolder.favoritesArray.forEach { bookmark in | ||
| bookmark.addToFavorites(favoritesRoot: mobileFavoritesFolder) | ||
| } | ||
| } else { | ||
| mobileFavoritesFolder.shouldManageModifiedAt = false | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.